xorm/xorm
xorm/xorm
63
356
Fork 206
Code Issues 372 Pull Requests 19 Actions Releases 35 Activity

Remove default length of 50 for Blob #1959

Merged
lunny merged 2 commits from zeripath/xorm:change-default-size-for-blobs-mssql into master 2021-07-23 00:59:54 +00:00
Conversation 2 Commits 2 Files Changed 1 +6 -1
zeripath commented 2021-06-26 21:04:48 +00:00
Contributor
Copy Link

There is an odd inconsistency with default blob sizes - this PR only sets the
default size for bytea and binary.

Signed-off-by: Andrew Thornton art27@cantab.net

There is an odd inconsistency with default blob sizes - this PR only sets the default size for bytea and binary. Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny commented 2021-06-27 03:13:07 +00:00
Owner
Copy Link

CI failed is related.

CI failed is related.
zeripath commented 2021-07-04 09:18:14 +00:00
Author
Contributor
Copy Link

Agh sorry I missed the CI failure.

I've updated to set that to MAX size

Agh sorry I missed the CI failure. I've updated to set that to MAX size
zeripath force-pushed change-default-size-for-blobs-mssql from 0466284dec to 4ab644369a 2021-07-20 19:45:03 +00:00 Compare
lunny reviewed 2021-07-20 23:52:17 +00:00
dialects/mssql.go Outdated
@ -310,1 +310,4 @@
}
case schemas.Blob, schemas.TinyBlob, schemas.MediumBlob, schemas.LongBlob:
res = schemas.VarBinary
if c.Length == -1 {
lunny commented 2021-07-20 23:52:17 +00:00
Owner
Copy Link

c.Length == 0?

`c.Length == 0`?
zeripath added 1 commit 2021-07-22 21:39:48 +00:00
as per lunny 
Signed-off-by: Andrew Thornton <art27@cantab.net>
All checks were successful
continuous-integration/drone/pr Build is passing
Details
cb2b96e875
lunny approved these changes 2021-07-23 00:59:49 +00:00
lunny merged commit ad4830f531 into master 2021-07-23 00:59:54 +00:00
zeripath deleted branch change-default-size-for-blobs-mssql 2021-07-23 07:42:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lunny
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#1959
No description provided.
Delete Branch "zeripath/xorm:change-default-size-for-blobs-mssql"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?