Remove default length of 50 for Blob #1959

Merged
lunny merged 2 commits from zeripath/xorm:change-default-size-for-blobs-mssql into master 2 months ago

There is an odd inconsistency with default blob sizes - this PR only sets the
default size for bytea and binary.

Signed-off-by: Andrew Thornton art27@cantab.net

There is an odd inconsistency with default blob sizes - this PR only sets the default size for bytea and binary. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added 1 commit 3 months ago
34994050a4
Remove default length of 50 for Blob
Owner

CI failed is related.

CI failed is related.
zeripath added 1 commit 3 months ago
ca4a4159d7
Just set Blob to Maxsize
Poster

Agh sorry I missed the CI failure.

I've updated to set that to MAX size

Agh sorry I missed the CI failure. I've updated to set that to MAX size
lunny added 1 commit 2 months ago
zeripath force-pushed change-default-size-for-blobs-mssql from 0466284dec to 4ab644369a 2 months ago
lunny reviewed 2 months ago
}
case schemas.Blob, schemas.TinyBlob, schemas.MediumBlob, schemas.LongBlob:
res = schemas.VarBinary
if c.Length == -1 {
lunny commented 2 months ago
Poster
Owner

c.Length == 0?

`c.Length == 0`?
zeripath added 1 commit 2 months ago
cb2b96e875
as per lunny
lunny approved these changes 2 months ago
lunny merged commit ad4830f531 into master 2 months ago
zeripath deleted branch change-default-size-for-blobs-mssql 2 months ago

Reviewers

lunny approved these changes 2 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as ad4830f531.
Sign in to join this conversation.
Loading…
There is no content yet.