Add interface to allow structs to provide specific index information #2137

Merged
lunny merged 2 commits from zeripath/xorm:index-manipulation into master 4 weeks ago
zeripath commented 4 weeks ago
Collaborator

The current mechanism for adding information about indices cannot express the ordering
of the columns in the index or add sorting information.

Here we add a new interface TableIndices which a struct would implement to provide
a slice of *schema.Index to provide additional indices to that gleaned from the tags.

Signed-off-by: Andrew Thornton art27@cantab.net

The current mechanism for adding information about indices cannot express the ordering of the columns in the index or add sorting information. Here we add a new interface TableIndices which a struct would implement to provide a slice of *schema.Index to provide additional indices to that gleaned from the tags. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added the
kind/enhancement
label 4 weeks ago
zeripath added 1 commit 4 weeks ago
152e1bcc69
Add interface to allow structs to provide specific index information
Owner

Could you add some tests for that?

Could you add some tests for that?
zeripath added 1 commit 4 weeks ago
a7a3984d36
add testcase
lunny approved these changes 4 weeks ago
lunny added this to the 1.3.1 milestone 4 weeks ago
lunny merged commit 26d291bbc3 into master 4 weeks ago
zeripath deleted branch index-manipulation 4 weeks ago

Reviewers

lunny approved these changes 4 weeks ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 26d291bbc3.
Sign in to join this conversation.
Loading…
There is no content yet.