Labels Milestones

Add interface to allow structs to provide specific index information #2137

Merged

lunny merged 2 commits from zeripath/xorm:index-manipulation into master 4 weeks ago

Conversation 1 Commits 2 Files Changed 2

zeripath commented 4 weeks ago

Collaborator

The current mechanism for adding information about indices cannot express the ordering
of the columns in the index or add sorting information.

Here we add a new interface TableIndices which a struct would implement to provide
a slice of *schema.Index to provide additional indices to that gleaned from the tags.

Signed-off-by: Andrew Thornton art27@cantab.net

The current mechanism for adding information about indices cannot express the ordering of the columns in the index or add sorting information. Here we add a new interface TableIndices which a struct would implement to provide a slice of *schema.Index to provide additional indices to that gleaned from the tags. Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath added the

kind/enhancement

label 4 weeks ago

zeripath added 1 commit 4 weeks ago

continuous-integration/drone/pr Build is passing

Details

152e1bcc69

Add interface to allow structs to provide specific index information ...

The current mechanism for adding information about indices cannot express the ordering
of the columns in the index or add sorting information.

Here we add a new interface TableIndices which a struct would implement to provide
a slice of *schema.Index to provide additional indices to that gleaned from the tags.

Signed-off-by: Andrew Thornton <art27@cantab.net>

lunny commented 4 weeks ago

Owner

Could you add some tests for that?

Could you add some tests for that?

zeripath added 1 commit 4 weeks ago

continuous-integration/drone/pr Build is passing

Details

a7a3984d36

add testcase ...

Signed-off-by: Andrew Thornton <art27@cantab.net>

lunny approved these changes 4 weeks ago

lunny added this to the 1.3.1 milestone 4 weeks ago

lunny merged commit 26d291bbc3 into master 4 weeks ago

lunny referenced this issue from a commit 4 weeks ago

Add interface to allow structs to provide specific index information (#2137)

zeripath deleted branch index-manipulation 4 weeks ago

Reviewers

lunny approved these changes 4 weeks ago

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as 26d291bbc3.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

lunny

Labels

Apply labels

Clear labels

blocked db/oracle db/sqlserver duplicate feature/cache invalid kind/breaking kind/bug kind/build kind/dependencies kind/docs kind/driver kind/enhancement kind/feature kind/performance kind/proposal kind/proposal:accepted kind/question kind/refactor kind/regression kind/testing kind/upstream need/feedback need/test RaspBerry Pi skip-changelog wip wontfix

No Label blocked db/oracle db/sqlserver duplicate feature/cache invalid kind/breaking kind/bug kind/build kind/dependencies kind/docs kind/driver kind/enhancement kind/feature kind/performance kind/proposal kind/proposal:accepted kind/question kind/refactor kind/regression kind/testing kind/upstream need/feedback need/test RaspBerry Pi skip-changelog wip wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

1.3.1

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Write Preview

Loading…

Cancel

Save

There is no content yet.