Prevent Sync failure with non-regular indexes on Postgres #2174

zeripath · 2022-09-02T19:46:03Z

zeripath commented

2022-09-02 19:46:03 +00:00

When dropping indexes in Postgres if the index is non-regular we
should not attempt to regularise the index name as it is already correct.

Signed-off-by: Andrew Thornton art27@cantab.net

When dropping indexes in Postgres if the index is non-regular we should not attempt to regularise the index name as it is already correct. Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath added 1 commit 2022-09-02 19:46:04 +00:00

Prevent Sync failure with non-regular indexes on Postgres

When dropping indexes in Postgres if the index is non-regular we
should not attempt to regularise the index name as it is already correct.

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is passing

Details

af675201d3

lunny approved these changes 2022-09-03 02:12:10 +00:00

lunny merged commit c900ecc87f into master

2022-09-03 02:12:17 +00:00

lunny referenced this issue from a commit

2022-09-03 02:12:18 +00:00

Prevent Sync failure with non-regular indexes on Postgres (#2174)

zeripath deleted branch fix-postgres-sync-failure-with-non-regular-index

2022-09-03 06:45:42 +00:00

zeripath commented

2022-09-03 06:47:15 +00:00

@lunny have there been significant changes in xorm since we released 1.17 of gitea or can we just take the current head and backport to Gitea 1.17 ?

lunny commented

2022-09-03 07:10:33 +00:00

@lunny have there been significant changes in xorm since we released 1.17 of gitea or can we just take the current head and backport to Gitea 1.17 ?

Just minor changes, so I think it can be backport to Gitea v1.17. Let me have a tag at first.

> @lunny have there been significant changes in xorm since we released 1.17 of gitea or can we just take the current head and backport to Gitea 1.17 ? Just minor changes, so I think it can be backport to Gitea v1.17. Let me have a tag at first.

lunny added this to the 1.3.2 milestone 2022-09-03 07:10:43 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2174