xorm/xorm
xorm/xorm
63
360
Fork 208
Code Issues 373 Pull Requests 17 Actions Releases 35 Activity

fix Interface2Interface *sql.RawBytes light copy bug #2237

Closed
hsfish wants to merge 4 commits from master into master
pull from: master
merge into: xorm:master
Conversation 4 Commits 4 Files Changed 1 +47
hsfish commented 2023-03-15 11:22:49 +00:00
First-time contributor
Copy Link

修复一次性查询多条数据，row转换为map[string]interface{} []byte切片浅拷贝问题。

修复一次性查询多条数据，row转换为map[string]interface{} []byte切片浅拷贝问题。
hsfish added 1 commit 2023-03-15 11:22:51 +00:00
fix Interface2Interface *sql.RawBytes light copy bug
Some checks failed
continuous-integration/drone/pr Build is failing
Details
926930b7c5
lunny commented 2023-03-15 12:38:26 +00:00
Owner
Copy Link

What's the bug itself?

What's the bug itself?
hsfish commented 2023-03-15 13:13:23 +00:00
Author
First-time contributor
Copy Link

When the number returned by the session.QueryInterface query is greater than 1, the same sql.Bytes is used. Here is a shallow copy, which will contaminate the previous data. Lead to garbled strings

image

When the number returned by the session.QueryInterface query is greater than 1, the same sql.Bytes is used. Here is a shallow copy, which will contaminate the previous data. Lead to garbled strings ![image](/attachments/c492d8c9-946e-401f-a2c1-bea077a590bc)
image.png
224 KiB
lunny commented 2023-03-16 02:37:17 +00:00
Owner
Copy Link

When the number returned by the session.QueryInterface query is greater than 1, the same sql.Bytes is used. Here is a shallow copy, which will contaminate the previous data. Lead to garbled strings

image

Thanks to point out. Could you add some unit test here?

> When the number returned by the session.QueryInterface query is greater than 1, the same sql.Bytes is used. Here is a shallow copy, which will contaminate the previous data. Lead to garbled strings > > ![image](/attachments/c492d8c9-946e-401f-a2c1-bea077a590bc) Thanks to point out. Could you add some unit test here?
hsfish added 1 commit 2023-03-18 03:43:11 +00:00
add Interface2Interface sqlRowBytes same addr test case
Some checks failed
continuous-integration/drone/pr Build is failing
Details
141ce23b80
hsfish commented 2023-03-24 03:10:14 +00:00
Author
First-time contributor
Copy Link

I submitted a test case to see what else needs to be adjusted

I submitted a test case to see what else needs to be adjusted
hsfish added 1 commit 2023-07-03 10:13:34 +00:00
PR xorm master
Some checks failed
test cockroach / test cockroach (pull_request) Has been cancelled
Details
test mariadb / test mariadb (pull_request) Has been cancelled
Details
test mssql / test mssql (pull_request) Has been cancelled
Details
test mysql / test mysql (pull_request) Has been cancelled
Details
test mysql8 / test mysql8 (pull_request) Has been cancelled
Details
test postgres / test postgres (pull_request) Has been cancelled
Details
test sqlite / unit test & test sqlite (pull_request) Has been cancelled
Details
test tidb / test tidb (pull_request) Has been cancelled
Details
0b266873f1
hsfish added 1 commit 2023-07-03 10:15:59 +00:00
Merge pull request 'master' (#2) from xorm/xorm:master into master 
Reviewed-on: hsfish/xorm#2
Some checks failed
test cockroach / test cockroach (pull_request) Has been cancelled
Details
test mariadb / test mariadb (pull_request) Has been cancelled
Details
test mssql / test mssql (pull_request) Has been cancelled
Details
test mysql / test mysql (pull_request) Has been cancelled
Details
test mysql8 / test mysql8 (pull_request) Has been cancelled
Details
test postgres / test postgres (pull_request) Has been cancelled
Details
test sqlite / unit test & test sqlite (pull_request) Has been cancelled
Details
test tidb / test tidb (pull_request) Has been cancelled
Details
fa474ab33e
hsfish closed this pull request 2023-07-03 10:16:32 +00:00
Some checks failed
test cockroach / test cockroach (pull_request) Has been cancelled
Details
test mariadb / test mariadb (pull_request) Has been cancelled
Details
test mssql / test mssql (pull_request) Has been cancelled
Details
test mysql / test mysql (pull_request) Has been cancelled
Details
test mysql8 / test mysql8 (pull_request) Has been cancelled
Details
test postgres / test postgres (pull_request) Has been cancelled
Details
test sqlite / unit test & test sqlite (pull_request) Has been cancelled
Details
test tidb / test tidb (pull_request) Has been cancelled
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2237
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?