Filter support passing context (#2200) #2270

LinkinStars · 2023-05-30T10:14:34Z

LinkinStars commented

2023-05-30 10:14:34 +00:00

// Filter is an interface to filter SQL
type Filter interface {
---	Do(sql string) string
+++	Do(ctx context.Context, sql string) string
}

Adds a `Context` parameter to the `Do` method of the Filter interface.

Developers can rewrite SQL through the Filter Do method and need to get the necessary data from the Context to assist.

For example, get user information through Context, so that different users can use different tables. Another example is to get the flags through Context to add annotations to the SQL, and use the annotations to let the subsequent DB-Proxy to achieve read/write separation.

```diff // Filter is an interface to filter SQL type Filter interface { --- Do(sql string) string +++ Do(ctx context.Context, sql string) string } ``` ### Adds a `Context` parameter to the `Do` method of the Filter interface. Developers can rewrite SQL through the `Filter` `Do` method and **need to get the necessary data from the Context** to assist. For example, get user information through `Context`, so that different users can use different tables. Another example is to get the flags through `Context` to add annotations to the SQL, and use the annotations to let the subsequent `DB-Proxy` to achieve read/write separation.

LinkinStars added 1 commit 2023-05-30 10:14:37 +00:00

Filter support passing context (#2200 )

test mariadb / test mariadb (pull_request) Successful in 7m21s

Details

test mssql / test mssql (pull_request) Successful in 8m43s

Details

test mysql / test mysql (pull_request) Successful in 5m46s

Details

test mysql8 / test mysql8 (pull_request) Successful in 5m42s

Details

test postgres / test postgres (pull_request) Successful in 6m25s

Details

test sqlite / unit test & test sqlite (pull_request) Successful in 10m2s

Details

test tidb / test tidb (pull_request) Successful in 5m47s

Details

test cockroach / test cockroach (pull_request) Successful in 6m55s

Details

d00e239c3c

lunny approved these changes 2023-05-30 13:41:09 +00:00

lunny merged commit cb851a2f95 into master

2023-05-31 01:43:28 +00:00

lunny referenced this issue from a commit

2023-05-31 01:43:30 +00:00

Filter support passing context (#2200) (#2270)

martinvigg referenced this issue from a commit

2023-10-09 15:32:50 +00:00

Filter support passing context (#2200) (#2270)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2270

Filter support passing context (#2200) #2270

Adds a Context parameter to the Do method of the Filter interface.

Adds a `Context` parameter to the `Do` method of the Filter interface.