Remove dead code from session.SyncWithOptions() #2323

6543 · 2023-08-09T16:02:08Z

6543 commented

2023-08-09 16:02:08 +00:00

		sync.go
		Lines 229 to 231 in db7c264062
	
							var oriIndex *schemas.Index

							for name2, index2 := range oriTable.Indexes {

								if index.Equal(index2) {

as oriIndex only is not nil if index.Equal(index2)

and index.Equal(index2) check if oriIndex.Type == index.Type ... so it always is false

https://gitea.com/xorm/xorm/src/commit/db7c2640627d24539aa4607f50bcba7037ddd9e6/sync.go#L229-L231 as oriIndex only is **not** nil if index.Equal(index2) and index.Equal(index2) check if `oriIndex.Type == index.Type` ... so it always is false

6543 added 1 commit 2023-08-09 16:02:11 +00:00

remove dead code

test mariadb / test mariadb (pull_request) Successful in 4m52s

Details

test cockroach / test cockroach (pull_request) Successful in 7m37s

Details

test mssql / test mssql (pull_request) Successful in 5m45s

Details

test mysql / test mysql (pull_request) Successful in 4m51s

Details

test mysql8 / test mysql8 (pull_request) Successful in 5m4s

Details

test postgres / test postgres (pull_request) Successful in 5m42s

Details

test tidb / test tidb (pull_request) Successful in 5m33s

Details

test sqlite / unit test & test sqlite (pull_request) Successful in 8m35s

Details

d764facb5f

6543 requested review from lunny 2023-08-09 16:02:20 +00:00

6543 commented

2023-08-21 21:57:31 +00:00

@lunny did you had any time to dig into it?

lunny added 2 commits 2023-09-16 14:06:29 +00:00

Merge branch 'remove_dead-code_in_sync' of gitea.com:6543/xorm into 6543-remove_dead-code_in_sync 8a4c0a1926

Add test

test mariadb / test mariadb (pull_request) Successful in 4m43s

Details

test cockroach / test cockroach (pull_request) Successful in 6m54s

Details

test mysql / test mysql (pull_request) Successful in 4m57s

Details

test mssql / test mssql (pull_request) Successful in 5m48s

Details

test mysql8 / test mysql8 (pull_request) Successful in 5m14s

Details

test postgres / test postgres (pull_request) Successful in 5m39s

Details

test tidb / test tidb (pull_request) Successful in 5m17s

Details

test sqlite / unit test & test sqlite (pull_request) Successful in 8m15s

Details

66a2adf75f

lunny approved these changes 2023-09-16 14:07:16 +00:00

lunny added the

kind

refactor

label 2023-09-16 14:07:24 +00:00

lunny merged commit e5be0f4129 into master

2023-09-16 14:41:02 +00:00

lunny referenced this issue from a commit

2023-09-16 14:41:04 +00:00

Remove dead code from session.SyncWithOptions() (#2323)

martinvigg referenced this issue from a commit

2023-10-09 15:32:51 +00:00

Remove dead code from session.SyncWithOptions() (#2323)

CyJaySong referenced this issue from a commit

2023-10-28 01:53:23 +00:00

Remove dead code from session.SyncWithOptions() (#2323)

6543 deleted branch remove_dead-code_in_sync

2023-11-15 22:35:28 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2323

	var oriIndex *schemas.Index
	for name2, index2 := range oriTable.Indexes {
	if index.Equal(index2) {