fix: pg invalid query #2324

vishal-bihani · 2023-08-14T14:18:16Z

vishal-bihani commented

2023-08-14 14:18:16 +00:00

First-time contributor

For postgres dialect when GetColumn is used, and when schema is not empty then the resulting interpolated query is invalid.

Attaching the screenshots of the resulting query and the error below.

For postgres dialect when [GetColumn](https://gitea.com/xorm/xorm/src/branch/master/dialects/postgres.go#L1081) is used, and when schema is not empty then the resulting interpolated query is invalid. Attaching the screenshots of the resulting query and the error below.

Screenshot 2023-08-14 at 7.37.42 PM.png

545 KiB

Screenshot 2023-08-14 at 7.38.54 PM.png

172 KiB

vishal-bihani added 1 commit 2023-08-14 14:18:18 +00:00

fix: pg invalid query

test cockroach / test cockroach (pull_request) Successful in 7m44s

Details

test mariadb / test mariadb (pull_request) Successful in 4m28s

Details

test mysql / test mysql (pull_request) Successful in 5m4s

Details

test mssql / test mssql (pull_request) Successful in 6m4s

Details

test mysql8 / test mysql8 (pull_request) Successful in 5m11s

Details

test postgres / test postgres (pull_request) Successful in 5m54s

Details

test tidb / test tidb (pull_request) Successful in 5m30s

Details

test sqlite / unit test & test sqlite (pull_request) Successful in 8m25s

Details

c3e6e94f88

vishal-bihani requested review from lunny 2023-08-14 14:19:59 +00:00

vishal-bihani requested review from Maintainers 2023-08-15 08:22:14 +00:00

lunny reviewed 2023-08-15 08:31:49 +00:00

dialects/postgres.go

						
				@ -1079,3 +1079,3 @@

				    LEFT JOIN pg_class AS g ON p.confrelid = g.oid

				    LEFT JOIN INFORMATION_SCHEMA.COLUMNS s ON s.column_name=f.attname AND c.relname=s.table_name

				WHERE n.nspname= s.table_schema AND c.relkind = 'r' AND c.relname = $1%s AND f.attnum > 0 ORDER BY f.attnum;`

				WHERE n.nspname= s.table_schema AND c.relkind = 'r' AND c.relname = $1 %s AND f.attnum > 0 ORDER BY f.attnum;`

lunny commented

2023-08-15 08:31:49 +00:00

It's wired because there is a space before AND in line 1085

It's wired because there is a space before ` AND` in line 1085

vishal-bihani commented

2023-08-15 08:40:42 +00:00

First-time contributor

Oh wait, I noticed my version of xorm does not have space in line 1085. Will check and close this PR

vishal-bihani commented

2023-08-15 08:53:08 +00:00

First-time contributor

This issue was related to an older version.

vishal-bihani closed this pull request

2023-08-15 08:53:09 +00:00

test cockroach / test cockroach (pull_request) Successful in 7m44s

Details

test mariadb / test mariadb (pull_request) Successful in 4m28s

Details

test mysql / test mysql (pull_request) Successful in 5m4s

Details

test mssql / test mssql (pull_request) Successful in 6m4s

Details

test mysql8 / test mysql8 (pull_request) Successful in 5m11s

Details

test postgres / test postgres (pull_request) Successful in 5m54s

Details

test tidb / test tidb (pull_request) Successful in 5m30s

Details

test sqlite / unit test & test sqlite (pull_request) Successful in 8m25s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

xorm/Maintainers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2324