xorm/xorm
xorm/xorm
64
358
Fork 207
Code Issues 373 Pull Requests 18 Actions Releases 35 Activity

(feat) Add retry package #2336

Open
datbeohbbh wants to merge 1 commits from datbeohbbh/xorm:retry-helper into main
pull from: datbeohbbh/xorm:retry-helper
merge into: xorm:main
Conversation 1 Commits 1 Files Changed 8 +570
datbeohbbh commented 2023-09-27 15:02:56 +00:00
Contributor
Copy Link

Hi!
I would like to add retry package.
When working with distributed databases like TiDB, CockroachDB, YDB, client can get an transient error due to network, services unavailable, ...
With retry helper package, XORM engine can evaluate an error and decide to retry operation/transaction or not.

Hi! I would like to add `retry` package. When working with distributed databases like TiDB, CockroachDB, YDB, client can get an transient error due to network, services unavailable, ... With `retry` helper package, XORM engine can evaluate an error and decide to retry operation/transaction or not.
datbeohbbh added 1 commit 2023-09-27 15:02:57 +00:00
(feat) add retry package
Some checks failed
test cockroach / test cockroach (pull_request) Has been cancelled
Details
test mariadb / test mariadb (pull_request) Has been cancelled
Details
test mssql / test mssql (pull_request) Has been cancelled
Details
test mysql / test mysql (pull_request) Has been cancelled
Details
test mysql8 / test mysql8 (pull_request) Has been cancelled
Details
test postgres / test postgres (pull_request) Has been cancelled
Details
test sqlite / unit test & test sqlite (pull_request) Has been cancelled
Details
test tidb / test tidb (pull_request) Has been cancelled
Details
d7ef1d5115
datbeohbbh requested review from lunny 2023-09-27 15:43:01 +00:00
datbeohbbh commented 2023-10-16 01:04:16 +00:00
Author
Contributor
Copy Link

@lunny can you help me to review this PR, please?

@lunny can you help me to review this PR, please?
lunny added the
kind
enhancement
 label 2023-10-25 07:42:27 +00:00
lunny closed this pull request 2023-10-27 07:29:46 +00:00
lunny reopened this pull request 2023-10-27 07:39:55 +00:00
lunny changed target branch from master to main 2023-10-27 07:40:03 +00:00
lunny added this to the 2.0.0 milestone 2023-10-27 07:40:12 +00:00
Some checks failed
test cockroach / test cockroach (pull_request) Has been cancelled
Required
Details
test mariadb / test mariadb (pull_request) Has been cancelled
Required
Details
test mssql / test mssql (pull_request) Has been cancelled
Required
Details
test mysql / test mysql (pull_request) Has been cancelled
Required
Details
test mysql8 / test mysql8 (pull_request) Has been cancelled
Required
Details
test postgres / test postgres (pull_request) Has been cancelled
Required
Details
test sqlite / unit test & test sqlite (pull_request) Has been cancelled
Required
Details
test tidb / test tidb (pull_request) Has been cancelled
Required
Details
This pull request has changes conflicting with the target branch.
  • engine.go
  • interface.go
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u retry-helper:datbeohbbh-retry-helper
git checkout datbeohbbh-retry-helper
Sign in to join this conversation.
Reviewers
No reviewers
lunny
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
2.0.0
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2336
No description provided.
Delete Branch "datbeohbbh/xorm:retry-helper"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?