xorm/xorm
xorm/xorm
63
356
Fork 206
Code Issues 372 Pull Requests 18 Actions Releases 35 Activity

add IsZero check for custom struct column in the Update method #2417

Merged
lunny merged 5 commits from tylerthail2019/xorm:v1 into v1 2024-03-18 06:43:33 +00:00
Conversation 1 Commits 5 Files Changed 2 +75
tylerthail2019 commented 2024-02-22 11:16:10 +00:00
Contributor
Copy Link
No description provided.
tylerthail2019 added 1 commit 2024-02-22 11:16:11 +00:00
add IsZero check for custom struct column in the Update method
Some checks failed
test cockroach / test cockroach (pull_request) Has been cancelled
Details
test mariadb / test mariadb (pull_request) Has been cancelled
Details
test mssql / test mssql with collation (pull_request) Has been cancelled
Details
test mssql / test mssql (pull_request) Has been cancelled
Details
test mysql / test mysql (pull_request) Has been cancelled
Details
test mysql8 / test mysql8 (pull_request) Has been cancelled
Details
test postgres / test postgres (pull_request) Has been cancelled
Details
test sqlite / unit test & test sqlite (pull_request) Has been cancelled
Details
test tidb / test tidb (pull_request) Has been cancelled
Details
81bf7ac1eb
lunny approved these changes 2024-02-25 15:08:30 +00:00
lunny added the
kind
bug
 label 2024-02-25 15:08:46 +00:00
lunny added this to the 1.3.9 milestone 2024-02-25 15:08:56 +00:00
lunny added 1 commit 2024-02-25 16:17:16 +00:00
Merge branch 'v1' into v1
All checks were successful
test mssql / test mssql with collation (pull_request) Successful in 3m40s
Details
test mariadb / test mariadb (pull_request) Successful in 4m18s
Details
test mssql / test mssql (pull_request) Successful in 5m28s
Details
test mysql / test mysql (pull_request) Successful in 3m3s
Details
test cockroach / test cockroach (pull_request) Successful in 6m49s
Details
test mysql8 / test mysql8 (pull_request) Successful in 4m30s
Details
test postgres / test postgres (pull_request) Successful in 4m4s
Details
test tidb / test tidb (pull_request) Successful in 3m34s
Details
test sqlite / unit test & test sqlite (pull_request) Successful in 6m26s
Details
ea84c93373
lunny commented 2024-02-26 13:05:24 +00:00
Owner
Copy Link

Can you write a test?

Can you write a test?
tylerthail2019 added 1 commit 2024-02-26 14:25:46 +00:00
Add test for update method when custom struct column is zero value
Some checks failed
test mssql / test mssql with collation (pull_request) Successful in 3m9s
Details
test mariadb / test mariadb (pull_request) Successful in 3m11s
Details
test cockroach / test cockroach (pull_request) Successful in 5m21s
Details
test mssql / test mssql (pull_request) Successful in 3m18s
Details
test mysql / test mysql (pull_request) Successful in 3m50s
Details
test postgres / test postgres (pull_request) Failing after 2m15s
Details
test mysql8 / test mysql8 (pull_request) Failing after 3m27s
Details
test tidb / test tidb (pull_request) Successful in 2m20s
Details
test sqlite / unit test & test sqlite (pull_request) Failing after 4m8s
Details
9237798868
lunny added 1 commit 2024-03-18 03:43:28 +00:00
Merge branch 'v1' into v1
Some checks failed
test mariadb / test mariadb (pull_request) Successful in 13m52s
Details
test mssql / test mssql (pull_request) Successful in 14m22s
Details
test mssql / test mssql with collation (pull_request) Successful in 14m29s
Details
test cockroach / test cockroach (pull_request) Successful in 15m11s
Details
test postgres / test postgres (pull_request) Failing after 7m26s
Details
test mysql8 / test mysql8 (pull_request) Failing after 8m14s
Details
test sqlite / unit test & test sqlite (pull_request) Failing after 8m13s
Details
test mysql / test mysql (pull_request) Successful in 12m41s
Details
test tidb / test tidb (pull_request) Successful in 11m33s
Details
63f54e633a
lunny added 1 commit 2024-03-18 06:02:41 +00:00
Fix test
All checks were successful
test mariadb / test mariadb (pull_request) Successful in 14m15s
Details
test mssql / test mssql (pull_request) Successful in 14m44s
Details
test mssql / test mssql with collation (pull_request) Successful in 14m53s
Details
test cockroach / test cockroach (pull_request) Successful in 15m34s
Details
test mysql / test mysql (pull_request) Successful in 12m48s
Details
test tidb / test tidb (pull_request) Successful in 12m19s
Details
test mysql8 / test mysql8 (pull_request) Successful in 13m15s
Details
test sqlite / unit test & test sqlite (pull_request) Successful in 13m45s
Details
c4b5433155
lunny merged commit 34e62e9b4c into v1 2024-03-18 06:43:33 +00:00
lunny added the
frontport/main
 label 2024-03-18 06:43:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lunny
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
1.3.9
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2417
No description provided.
Delete Branch "tylerthail2019/xorm:v1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?