xorm/xorm
xorm/xorm
63
357
Fork 207
Code Issues 373 Pull Requests 18 Actions 9 Releases 35 Activity

Fix order by clause do not support empty string #2422

Closed
leiwingqueen wants to merge 20 commits from leiwingqueen/xorm:order_by_empty into v1
pull from: leiwingqueen/xorm:order_by_empty
merge into: xorm:v1
Conversation 0 Commits 20 Files Changed 143 +1961 -3400
leiwingqueen commented 2024-03-01 09:57:15 +00:00
First-time contributor
Copy Link

what happen

xorm 1.3.2 support order by clause support empty string and v1.3.8 throw an error to the caller. I want xorm support this feature in the future.

it will throw an error "order by string is empty" when I invoke the function OrderBy("").

We need this feature in the case that user can change order clause and empty string means no need to order the rows

expectation

testEngine.Where("age =1 ").OrderBy("") return success

# what happen xorm 1.3.2 support order by clause support empty string and v1.3.8 throw an error to the caller. I want xorm support this feature in the future. it will throw an error "order by string is empty" when I invoke the function OrderBy(""). We need this feature in the case that user can change order clause and empty string means no need to order the rows # expectation testEngine.Where("`age` =1 ").OrderBy("") return success
leiwingqueen added 20 commits 2024-03-01 09:57:16 +00:00
Some refactors (#2348) 
Reviewed-on: #2348
All checks were successful
test mysql8 / test mysql8 (pull_request) Successful in 2m50s
Details
test postgres / test postgres (pull_request) Successful in 3m46s
Details
test sqlite / unit test & test sqlite (pull_request) Successful in 3m40s
Details
test cockroach / test cockroach (pull_request) Successful in 4m38s
Details
test mssql / test mssql (pull_request) Successful in 4m57s
Details
test mariadb / test mariadb (pull_request) Successful in 5m23s
Details
test tidb / test tidb (pull_request) Successful in 3m20s
Details
test mysql / test mysql (pull_request) Successful in 3m35s
Details
8eeb1ef8ac
Remove cache features (#2347) 
The cache feature is not used frequently but needs more time to maintain.
I think there are many machism to handle the cache out of ORM. So let's remove it.

Reviewed-on: #2347
42553b7477
Fix #2393 (#2395) (#2396) 
Reviewed-on: #2395
Reviewed-on: #2396
3344b42b4b
Fix the issue of incorrect insertion of data in non UTC time zone zero for numeric types (#2359) 
Fix the issue of incorrect insertion of data in non UTC time zone zero for numeric types

Co-authored-by: CyJay <cyjay@MacBook-Pro.lan>
Reviewed-on: #2359
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: CyJaySong <CyJaySong@gmail.com>
Co-committed-by: CyJaySong <CyJaySong@gmail.com>
7601625664
order by function support empty value
Some checks failed
test cockroach / test cockroach (pull_request) Has been cancelled
Details
test mariadb / test mariadb (pull_request) Has been cancelled
Details
test mssql / test mssql with collation (pull_request) Has been cancelled
Details
test mssql / test mssql (pull_request) Has been cancelled
Details
test mysql / test mysql (pull_request) Has been cancelled
Details
test mysql8 / test mysql8 (pull_request) Has been cancelled
Details
test postgres / test postgres (pull_request) Has been cancelled
Details
test sqlite / unit test & test sqlite (pull_request) Has been cancelled
Details
test tidb / test tidb (pull_request) Has been cancelled
Details
954247036a
leiwingqueen closed this pull request 2024-03-01 10:13:29 +00:00
Some checks failed
test cockroach / test cockroach (pull_request) Has been cancelled
Required
Details
test mariadb / test mariadb (pull_request) Has been cancelled
Required
Details
test mssql / test mssql with collation (pull_request) Has been cancelled
Required
Details
test mssql / test mssql (pull_request) Has been cancelled
Required
Details
test mysql / test mysql (pull_request) Has been cancelled
Required
Details
test mysql8 / test mysql8 (pull_request) Has been cancelled
Required
Details
test postgres / test postgres (pull_request) Has been cancelled
Required
Details
test sqlite / unit test & test sqlite (pull_request) Has been cancelled
Required
Details
test tidb / test tidb (pull_request) Has been cancelled
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backport/done

   
backport/v1

   
blocked
  
db
oracle

  
db
sqlserver

  
duplicate
  
feature
cache

  
frontport/done

   
frontport/main

   
invalid
  
kind
breaking

  
kind
bug

  
kind
build

  
kind
dependencies

  
kind
docs

  
kind
driver

  
kind
enhancement

  
kind
feature

  
kind
performance

  
kind
proposal

  
kind
question

  
kind
refactor

  
kind
testing

  
need
feedback

  
need
test

  
proposal:accepted

   
RaspBerry Pi

   
regression

   
skip-changelog

   
upstream

   
wip

   
wontfix
No Label
backport/done
backport/v1
blocked
db
oracle
db
sqlserver
duplicate
feature
cache
frontport/done
frontport/main
invalid
kind
breaking
kind
bug
kind
build
kind
dependencies
kind
docs
kind
driver
kind
enhancement
kind
feature
kind
performance
kind
proposal
kind
question
kind
refactor
kind
testing
need
feedback
need
test
proposal:accepted
RaspBerry Pi
regression
skip-changelog
upstream
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/xorm#2422
No description provided.
Delete Branch "leiwingqueen/xorm:order_by_empty"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?