Catch the panic and print the error #215

lunny · 2023-05-26T05:44:04Z

lunny commented

2023-05-26 05:44:04 +00:00

No description provided.

lunny added 1 commit 2023-05-26 05:44:06 +00:00

Catch the panic and print the error

checks / check and test (pull_request) Successful in 56s

Details

418dedce30

wxiaoguang reviewed 2023-05-26 05:47:11 +00:00

internal/app/poll/poller.go

						
				@ -51,0 +50,4 @@

							defer func() {

								if r := recover(); r != nil {

									// we don't know whether log will panic, so just use fmt

									fmt.Printf("panic: %v\n", r)

wxiaoguang commented

2023-05-26 05:47:11 +00:00

The logger should never panic ...

I would prefer to always use the logger system.

The logger should never panic ... I would prefer to always use the logger system.

👍 1

wxiaoguang reviewed 2023-05-26 05:48:38 +00:00

internal/app/poll/poller.go

						
				@ -51,0 +52,4 @@

									// we don't know whether log will panic, so just use fmt

									fmt.Printf("panic: %v\n", r)

								}

							}()

wxiaoguang commented

2023-05-26 05:48:38 +00:00

The for { func() defer func() { seems quite complex, could the code block be moved into a separate function? Then it's easier to do defer - recover.

The `for { func() defer func() {` seems quite complex, could the code block be moved into a separate function? Then it's easier to do defer - recover.