feat: improve Docker configuration and detection handling #242

appleboy · 2023-06-16T22:30:41Z

appleboy commented

2023-06-16 22:30:41 +00:00

Pass cfg to envcheck.CheckIfDockerRunning function
Add Docker struct to config.go for Docker configuration
Update config.example.yaml with docker configuration options
Modify CheckIfDockerRunning in docker.go to use Docker host from config if provided

Signed-off-by: appleboy appleboy.tw@gmail.com

- Pass `cfg` to `envcheck.CheckIfDockerRunning` function - Add `Docker` struct to `config.go` for Docker configuration - Update `config.example.yaml` with `docker` configuration options - Modify `CheckIfDockerRunning` in `docker.go` to use Docker host from config if provided Signed-off-by: appleboy <appleboy.tw@gmail.com>

appleboy added the

kind

enhancement

label 2023-06-16 22:30:41 +00:00

appleboy added 1 commit 2023-06-16 22:30:44 +00:00

feat: improve Docker configuration and detection handling

- Pass `cfg` to `envcheck.CheckIfDockerRunning` function
- Add `Docker` struct to `config.go` for Docker configuration
- Update `config.example.yaml` with `docker` configuration options
- Modify `CheckIfDockerRunning` in `docker.go` to use Docker host from config if provided

Signed-off-by: appleboy <appleboy.tw@gmail.com>

checks / check and test (pull_request) Successful in 39s

Details

56a7c930f8

appleboy requested review from lunny 2023-06-16 22:30:58 +00:00

appleboy requested review from wolfogre 2023-06-16 22:30:59 +00:00

lunny approved these changes 2023-06-17 03:02:24 +00:00

wxiaoguang approved these changes 2023-06-17 03:03:03 +00:00

appleboy commented

2023-06-17 06:58:28 +00:00

@lunny @wxiaoguang Please help to merge. I don't have permission.

wxiaoguang commented

2023-06-17 12:55:47 +00:00

@lunny @wxiaoguang Please help to merge. I don't have permission.

I don't, either.

You are not authorized to merge this pull request.

> @lunny @wxiaoguang Please help to merge. I don't have permission. I don't, either. > You are not authorized to merge this pull request.

lunny merged commit 9e4a5f7363 into main

2023-06-18 05:38:41 +00:00

lunny referenced this issue from a commit

2023-06-18 05:38:43 +00:00

feat: improve Docker configuration and detection handling (#242)

wolfogre commented

2023-06-19 06:31:15 +00:00

Why not container.docker_host? There are some options for docker/container in container. Developers could get confused about where to add options.

Why not `container.docker_host`? There are some options for docker/container in `container`. Developers could get confused about where to add options.

wolfogre referenced this pull request

2023-06-19 06:49:09 +00:00

Move `docker.host` to `container.docker_host` #244

wolfogre referenced this issue from a commit

2023-06-19 09:01:21 +00:00

Move `docker.host` to `container.docker_host` (#244)

ccureau referenced this issue from a commit

2023-06-22 22:45:00 +00:00

feat: improve Docker configuration and detection handling (#242)

Zettat123 referenced this pull request

2023-06-28 10:18:11 +00:00

Improve the usage of `docker_host` configuration #260