ci(lint): refactor code for clarity and linting compliance #289

appleboy · 2023-07-13T01:08:40Z

appleboy commented

2023-07-13 01:08:40 +00:00

Removed deadcode, structcheck, and varcheck linters from .golangci.yml
Fixed a typo in a comment in daemon.go
Renamed defaultActionsUrl to defaultActionsURL in exec.go
Removed unnecessary else clause in exec.go and runner.go
Simplified variable initialization in exec.go
Changed function name from getHttpClient to getHTTPClient in http.go
Removed unnecessary else clause in labels_test.go

Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com

- Removed `deadcode`, `structcheck`, and `varcheck` linters from `.golangci.yml` - Fixed a typo in a comment in `daemon.go` - Renamed `defaultActionsUrl` to `defaultActionsURL` in `exec.go` - Removed unnecessary else clause in `exec.go` and `runner.go` - Simplified variable initialization in `exec.go` - Changed function name from `getHttpClient` to `getHTTPClient` in `http.go` - Removed unnecessary else clause in `labels_test.go` Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

appleboy added 1 commit 2023-07-13 01:08:47 +00:00

ci(lint): refactor code for clarity and linting compliance

- Removed `deadcode`, `structcheck`, and `varcheck` linters from `.golangci.yml`
- Fixed a typo in a comment in `daemon.go`
- Renamed `defaultActionsUrl` to `defaultActionsURL` in `exec.go`
- Removed unnecessary else clause in `exec.go` and `runner.go`
- Simplified variable initialization in `exec.go`
- Changed function name from `getHttpClient` to `getHTTPClient` in `http.go`
- Removed unnecessary else clause in `labels_test.go`

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

checks / check and test (pull_request) Successful in 59s

Details

1217a5cec3

appleboy requested review from lunny 2023-07-13 01:09:11 +00:00

appleboy requested review from wolfogre 2023-07-13 01:09:12 +00:00

appleboy added the

kind

refactor

label 2023-07-13 01:09:58 +00:00

lunny approved these changes 2023-07-13 01:10:07 +00:00

lunny merged commit db662b3690 into main

2023-07-13 01:10:57 +00:00