Improve the explanation of workdir_parent config #519

Zettat123 · 2024-03-19T09:06:58Z

Zettat123 commented

2024-03-19 09:06:58 +00:00

act_runner adds a '/' before the path (see

		internal/app/run/runner.go
		Line 186 in 5977042b86
	
						Workdir:        filepath.FromSlash(fmt.Sprintf("/%s/%s", r.cfg.Container.WorkdirParent, preset.Repository)),

) . So workdir_parent doesn't need to have the prefix '/'.

If workdir_parent has the prefix '/', errors will occur when reading files from the job container.

Fix #512 act_runner adds a '/' before the path (see https://gitea.com/gitea/act_runner/src/commit/5977042b86f22454d51c8027a009cb0a40337e52/internal/app/run/runner.go#L186) . So `workdir_parent` doesn't need to have the prefix '/'. If `workdir_parent` has the prefix '/', errors will occur when reading files from the job container.

Zettat123 added 1 commit 2024-03-19 09:06:58 +00:00

update comment

checks / check and test (pull_request) Successful in 50s

Details

494c23db81

Zettat123 added the

kind

bug

label 2024-03-19 09:07:11 +00:00

wolfogre commented

2024-03-20 05:53:22 +00:00

Maybe we can simply fix the code to handle it instead of requesting it in the configuration.

Zettat123 commented

2024-03-20 06:45:44 +00:00

I considered changing the code from

fmt.Sprintf("/%s/%s", r.cfg.Container.WorkdirParent, preset.Repository)

to

fmt.Sprintf("%s/%s", r.cfg.Container.WorkdirParent, preset.Repository)

My concern is that maybe some users are using this configuration. Should we introduce a BREAKING change?

I considered changing the code from ``` fmt.Sprintf("/%s/%s", r.cfg.Container.WorkdirParent, preset.Repository) ``` to ``` fmt.Sprintf("%s/%s", r.cfg.Container.WorkdirParent, preset.Repository) ``` My concern is that maybe some users are using this configuration. Should we introduce a BREAKING change?

wolfogre commented

2024-03-20 08:08:01 +00:00

I mean:

fmt.Sprintf("/%s/%s", strings.TrimLeft(r.cfg.Container.WorkdirParent, "/"), preset.Repository)

I mean: ```go fmt.Sprintf("/%s/%s", strings.TrimLeft(r.cfg.Container.WorkdirParent, "/"), preset.Repository) ```

❤️ 1

Zettat123 added 1 commit 2024-03-22 02:11:58 +00:00

fix workdir

checks / check and test (pull_request) Successful in 1m12s

Details

77f290c888

Zettat123 added 1 commit 2024-03-22 02:15:11 +00:00

update workdir_parent comment

checks / check and test (pull_request) Successful in 1m9s

Details

4314e5f7a4

Zettat123 requested review from wolfogre 2024-03-22 02:17:27 +00:00

wolfogre approved these changes 2024-03-22 02:30:18 +00:00

wolfogre merged commit a1fc2b3ca7 into main

2024-03-22 02:30:31 +00:00

wolfogre referenced this issue from a commit

2024-03-22 02:30:33 +00:00

Improve the explanation of `workdir_parent` config (#519)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#519

Improve the explanation of workdir_parent config #519

Improve the explanation of `workdir_parent` config #519