Use node 20 by default #526

wolfogre · 2024-03-28T03:44:57Z

wolfogre commented

2024-03-28 03:44:57 +00:00

Because Octokit requires Node 18 or higher now.

See https://github.com/octokit/octokit.js/#fetch-missing .

However, for existing runners, users should manually modify labels in the .runner file or runner.labels in the config.yaml file to update. Don't forget to restart.

Because Octokit requires Node 18 or higher now. See https://github.com/octokit/octokit.js/#fetch-missing . However, for existing runners, users should manually modify `labels` in the `.runner` file or `runner.labels` in the `config.yaml` file to update. Don't forget to restart.

wolfogre added 1 commit 2024-03-28 03:44:57 +00:00

chore: use node 18 by defult

checks / check and test (pull_request) Successful in 38s

Details

3a18c868b5

sillyguodong commented

2024-03-28 03:55:12 +00:00

There may be some places that need to be modified too.

There may be some places that need to be modified too. ![image](/attachments/c548db28-1d1a-4383-9c0f-f6d0d4172412)

image.png

189 KiB

👍 1

silverwind commented

2024-03-28 17:49:42 +00:00

Wouldn't 20 be a better choice? Most actions run on node 20 since a few months and it will have one more year of support.

See https://github.com/nodejs/Release/?tab=readme-ov-file#release-schedule regarding support cycles.

Wouldn't 20 be a better choice? Most actions run on node 20 since a few months and it will have one more year of support. See https://github.com/nodejs/Release/?tab=readme-ov-file#release-schedule regarding support cycles.

👍 1

techknowlogick commented

2024-03-28 18:53:37 +00:00

+1 for going directly to 20

👍 2

wolfogre added 2 commits 2024-03-29 02:40:14 +00:00

chore: update comments a7b1499fae

chore: use node 20

checks / check and test (pull_request) Successful in 39s

Details

98e36d4c9f

wolfogre changed title from ~~Use node 18 by default~~ to Use node 20 by default

2024-03-29 02:40:26 +00:00

sillyguodong approved these changes 2024-03-29 02:55:48 +00:00

wolfogre merged commit 94c45acf6b into main

2024-03-29 03:03:29 +00:00

wolfogre referenced this issue from a commit

2024-03-29 03:03:29 +00:00

Use node 20 by default (#526)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#526