gitea/act_runner
61
106
Fork 79
Code Issues 137 Pull Requests 9 Actions Releases 21 Activity

WIP: Add token to config when creating new runner #97

Closed
Zettat123 wants to merge 1 commits from Zettat123/act_runner:local-private-reusable-workflow into main
pull from: Zettat123/act_runner:local-private-reusable-workflow
merge into: gitea:main
Conversation 3 Commits 1 Files Changed 1 +1
Zettat123 commented 2023-04-04 09:14:38 +00:00
Member
Copy Link

Partially fixes #91

Add token to runner config so the runner can access the reusable workflows from the same repository.

This PR is from #91 (comment) . Thanks @gjabell for the idea.

Partially fixes #91 Add token to runner config so the runner can access the reusable workflows from the same repository. This PR is from https://gitea.com/gitea/act_runner/issues/91#issuecomment-734544 . Thanks @gjabell for the idea.
Zettat123 added 1 commit 2023-04-04 09:14:39 +00:00
add token to config
All checks were successful
checks / check and test (pull_request) Successful in 1m22s
Details
cd847e3e93
Zettat123 commented 2023-04-04 09:18:22 +00:00
Author
Member
Copy Link

This can only allow a workflow to reuse the workflows from the same repository. As for the workflows from external private repositories, we need to do more work and make another PR to fix.

This can only allow a workflow to reuse the workflows from the same repository. As for the workflows from external private repositories, we need to do more work and make another PR to fix.
lunny approved these changes 2023-04-04 09:20:28 +00:00
wolfogre requested changes 2023-04-04 10:34:42 +00:00
wolfogre left a comment
Owner
Copy Link

Does it related to gitea/act#6 ?

The case is:

  • The actions repo is public on gitea.com
  • Clone it with a token from my_gitea.com
  • It will fail because the token is wrong even if the repo is public.
  • And gitea.com get a token not belonging to it, it can do bad thing now.
Does it related to https://gitea.com/gitea/act/pulls/6 ? The case is: - The actions repo is public on gitea.com - Clone it with a token from my_gitea.com - It will fail because the token is wrong even if the repo is public. - And gitea.com get a token not belonging to it, it can do bad thing now.
👍 1
Zettat123 commented 2023-04-04 10:42:24 +00:00
Author
Member
Copy Link

Does it related to gitea/act#6 ?

That's right. I'll rewrite this PR.

> Does it related to https://gitea.com/gitea/act/pulls/6 ? That's right. I'll rewrite this PR.
Zettat123 changed title from Add token to config when creating new runner to WIP: Add token to config when creating new runner 2023-04-04 10:43:01 +00:00
Zettat123 commented 2023-04-06 02:35:34 +00:00
Author
Member
Copy Link

Made some improvements for getting reusable workflows from the same repository in gitea/act#38 . Looks like we don't need to change the logic in act_runner so I will close this PR.

Made some improvements for getting reusable workflows from the same repository in https://gitea.com/gitea/act/pulls/38 . Looks like we don't need to change the logic in `act_runner` so I will close this PR.
Zettat123 closed this pull request 2023-04-06 02:35:34 +00:00
All checks were successful
checks / check and test (pull_request) Successful in 1m22s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
lunny
wolfogre
Labels
Clear labels   
kind
bug
Something is not working

  
kind
build

  
kind/compatible
  
kind
dependencies

  
kind
docs

  
kind
enhancement
New feature

  
kind
feature

  
kind
help wanted
Need some help

  
kind
proposal

  
kind
refactor

  
related
act
Related to act.

  
related
environment
Related to the environment.

  
related
exec

  
related
gitea
Related to Gitea.

  
related
workflow
Related to the workflow file or actions scripts.

  
reviewed
confirmed
confirmed issue

  
reviewed
duplicate
This issue or pull request already exists

  
reviewed
invalid
Something is wrong

  
reviewed
needs feedback

  
reviewed
wontfix
This won't be fixed

  
reviewed
workaround

No Label
kind
bug
kind
build
kind/compatible
kind
dependencies
kind
docs
kind
enhancement
kind
feature
kind
help wanted
kind
proposal
kind
refactor
related
act
related
environment
related
exec
related
gitea
related
workflow
reviewed
confirmed
reviewed
duplicate
reviewed
invalid
reviewed
needs feedback
reviewed
wontfix
reviewed
workaround
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/act_runner#97
No description provided.
Delete Branch "Zettat123/act_runner:local-private-reusable-workflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?