gitea/changelog
43
16
Fork 11
Code Issues 11 Pull Requests 1 Actions Releases 5 Wiki Activity

Updates and priority changes #62

Merged
lunny merged 3 commits from jolheiser/changelog:priority into master 2022-06-22 01:27:24 +00:00
Conversation 0 Commits 3 Files Changed 14 +169 -266
jolheiser commented 2022-06-20 18:40:22 +00:00
Owner
Copy Link

Closes #61

This PR does some general cleanup and implements pseudo-priority based on the order defined in the changelog config.

It makes use of the embed package and removes the workaround that was previously used for the default config.

It updates go.mod to go 1.18, but this shouldn't be a problem as changelog is mostly an internal tool.

It also changes a few variables to be non-exported in order to better control their scope.

Closes #61 This PR does some general cleanup and implements pseudo-priority based on the order defined in the changelog config. It makes use of the `embed` package and removes the workaround that was previously used for the default config. It updates `go.mod` to `go 1.18`, but this shouldn't be a problem as changelog is mostly an internal tool. It also changes a few variables to be non-exported in order to better control their scope.
👍 2
jolheiser added 1 commit 2022-06-20 18:40:22 +00:00
Updates and priority changes 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Some checks failed
continuous-integration/drone/pr Build is failing
Details
e7dfba2ca2
6543 reviewed 2022-06-20 18:48:57 +00:00
.drone.yml Outdated
@ -15,7 +15,7 @@ steps:
pull: always
image: golang:1.17
6543 commented 2022-06-20 18:48:57 +00:00
Owner
Copy Link

1.18

1.18
jolheiser marked this conversation as resolved
jolheiser added 1 commit 2022-06-20 18:51:11 +00:00
Update Go version in Drone 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Some checks failed
continuous-integration/drone/pr Build is failing
Details
d566d8a85f
6543 reviewed 2022-06-20 18:51:36 +00:00
cmd/generate.go
@ -51,0 +44,4 @@
}
}
if defaultGroup == "" {
defaultGroup = cfg.Groups[len(cfg.Groups)-1].Name
6543 commented 2022-06-20 18:51:36 +00:00
Owner
Copy Link

should we just drop if there is no default group and no group match?

should we just drop if there is no default group and no group match?
jolheiser commented 2022-06-20 18:52:17 +00:00
Author
Owner
Copy Link

I'm ambivalent, but that would technically be a breaking change. This is how the old logic worked.

I'm ambivalent, but that would technically be a breaking change. This is how the old logic worked.
👍 1
6543 commented 2022-06-20 19:11:14 +00:00
Owner
Copy Link

something for next pull ;)

I think we should break this but agree - this is out of scope for this pull

something for next pull ;) I think we should break this but agree - this is out of scope for this pull
6543 marked this conversation as resolved
6543 reviewed 2022-06-20 19:10:26 +00:00
cmd/cmd.go Outdated
@ -1,24 +1,84 @@
// Copyright 2020 The Gitea Authors. All rights reserved.
6543 commented 2022-06-20 19:10:26 +00:00
Owner
Copy Link

intentional?!?

intentional?!?
jolheiser commented 2022-06-20 19:40:37 +00:00
Author
Owner
Copy Link

Ah, nope. I had deleted the file and then renamed a different one to this, but forgot a new copyright.

Ah, nope. I had deleted the file and then renamed a different one to this, but forgot a new copyright.
jolheiser marked this conversation as resolved
6543 reviewed 2022-06-20 19:14:15 +00:00
Makefile
@ -27,3 +26,4 @@
$(GO) test -race -v ./...
.PHONY: lint
lint:
6543 commented 2022-06-20 19:14:15 +00:00
Owner
Copy Link

I think we should switch to use go install ... here

I think we should switch to use `go install ...` here
jolheiser commented 2022-06-20 19:39:59 +00:00
Author
Owner
Copy Link

Or go run, now that Go supports versioned running

Or `go run`, now that Go supports versioned running
jolheiser marked this conversation as resolved
jolheiser added 1 commit 2022-06-20 19:56:28 +00:00
Update golangci-lint and re-add copyright 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
All checks were successful
continuous-integration/drone/pr Build is passing
Details
a03fb2ecad
lunny reviewed 2022-06-21 05:46:47 +00:00
cmd/generate.go
@ -48,3 +38,3 @@
}
processPRs(prs, cfg.SkipRegex)
var defaultGroup string
lunny commented 2022-06-21 05:46:47 +00:00
Owner
Copy Link

Shouldn't these code be invoked before service.New?

Shouldn't these code be invoked before `service.New`?
6543 commented 2022-06-21 12:08:40 +00:00
Owner
Copy Link

I dont see it in use before ... so more a code-convention thing when to init vars?

I'm ok as it's done atm by the way...

I dont see it in use before ... so more a code-convention thing when to init vars? I'm ok as it's done atm by the way...
jolheiser commented 2022-06-21 21:23:44 +00:00
Author
Owner
Copy Link

I always init the var right before I need it. In terms of service.New, the service is only responsible for getting entries, not for grouping them. That happens further down.

I always init the var right before I need it. In terms of `service.New`, the service is only responsible for getting entries, not for grouping them. That happens further down.
👍 1
lunny marked this conversation as resolved
6543 approved these changes 2022-06-21 12:08:43 +00:00
lunny approved these changes 2022-06-22 01:27:02 +00:00
lunny merged commit 57e620da5b into master 2022-06-22 01:27:24 +00:00
jolheiser added the
enhancement
 label 2022-06-22 02:52:16 +00:00
jolheiser added this to the v0.3.0 milestone 2022-06-22 02:52:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
6543
lunny
Labels
Clear labels   
breaking

   
bug

   
build

Changes to builds

  
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid
  
lgtm
done

  
lgtm
need 1

  
question

   
skip-changelog

   
wontfix
No Label
breaking
bug
build
duplicate
enhancement
feature
help wanted
invalid
lgtm
done
lgtm
need 1
question
skip-changelog
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.3.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/changelog#62
No description provided.
Delete Branch "jolheiser/changelog:priority"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?