on failure error messages are discarded #582

New Issue

dachary · 2022-04-26T15:41:54Z

dachary commented

2022-04-26 15:41:54 +00:00

During error handling the body of the response is read. If an error occurs (for instance 404) the data is returned (and passed to the caller) but eventually discarded.

As a result the error message is lost. An alternative would be for the caller to read it again from the body. However this is no longer possible because it is closed.

The only workaround is to manually craft the API call and repeat it with curl like so:

$ curl --verbose -H "content-type: application/json"  --data '{"title":"title","body":"body","head":"XVlBzgba:feature","base":"master"}' -H "Authorization: token REDACTED" "http://127.0.0.1:8781/api/v1/repos/root/XVlBzgba/pulls"
{"errors":null,"message":"GetUserByName","url":"http://0.0.0.0:8781/api/swagger"}

During [error handling](https://gitea.com/gitea/go-sdk/src/branch/master/gitea/client.go#L257-L293) the body of the response is read. If an error occurs (for [instance 404](https://gitea.com/gitea/go-sdk/src/branch/master/gitea/client.go#L257-L293)) the data is returned (and [passed to the caller](https://gitea.com/gitea/go-sdk/src/branch/master/gitea/client.go#L305)) but [eventually discarded](https://gitea.com/gitea/go-sdk/src/branch/master/gitea/client.go#L320). As a result the error message is lost. An alternative would be for the caller to read it again from the body. However this [is no longer possible](https://gitea.com/gitea/go-sdk/issues/551) because it is closed. The only workaround is to manually craft the API call and repeat it with curl like so: ``` $ curl --verbose -H "content-type: application/json" --data '{"title":"title","body":"body","head":"XVlBzgba:feature","base":"master"}' -H "Authorization: token REDACTED" "http://127.0.0.1:8781/api/v1/repos/root/XVlBzgba/pulls" {"errors":null,"message":"GetUserByName","url":"http://0.0.0.0:8781/api/swagger"} ```

jolheiser referenced a pull request that will close this issue

2022-04-26 20:00:37 +00:00

Return error message for 4xx errors #583

6543 closed this issue

2022-04-28 02:56:33 +00:00

6543 referenced this issue from a commit

2022-04-28 02:56:34 +00:00

Return error message for 4xx errors (#583)

Sign in to join this conversation.