Add Release Subcomands #195

Merged
6543 merged 10 commits from 6543/tea:enhance-release into master 2020-09-23 19:56:42 +00:00

View File

@ -5,9 +5,12 @@
package cmd
import (
"fmt"
"log"
"net/http"
"os"
"path/filepath"
"strings"
"code.gitea.io/sdk/gitea"
@ -16,16 +19,29 @@ import (
// CmdReleases represents to login a gitea server.
var CmdReleases = cli.Command{
Name: "releases",
Usage: "Create releases",
Description: `Create releases`,
Name: "release",
Aliases: []string{"releases"},
Usage: "Manage releases",
Description: "Manage releases",
Action: runReleases,
Subcommands: []*cli.Command{
&CmdReleaseList,
&CmdReleaseCreate,
&CmdReleaseDelete,
&CmdReleaseEdit,
},
Flags: AllDefaultFlags,
}
// CmdReleaseList represents a sub command of Release to list releases
var CmdReleaseList = cli.Command{
Name: "ls",
Usage: "List Releases",
Description: "List Releases",
Action: runReleases,
noerw marked this conversation as resolved
Review

While we're at it, it might be nice to add a 'prerelease/draftfilter flag fortea releases ls`?

While we're at it, it might be nice to add a 'prerelease`/`draft` filter flag for `tea releases ls`?
Review

Not supported by the sdk

Not supported by the sdk
Review

.. and api

.. and api
Flags: AllDefaultFlags,
}
func runReleases(ctx *cli.Context) error {
login, owner, repo := initCommand()
@ -38,6 +54,7 @@ func runReleases(ctx *cli.Context) error {
"Tag-Name",
"Title",
"Published At",
"Status",
"Tar URL",
}
@ -49,12 +66,19 @@ func runReleases(ctx *cli.Context) error {
}
for _, release := range releases {
status := "released"
if release.IsDraft {
status = "draft"
} else if release.IsPrerelease {
status = "prerelease"
}
values = append(
values,
[]string{
release.TagName,
release.Title,
release.PublishedAt.Format("2006-01-02 15:04:05"),
status,
release.TarURL,
},
)
@ -64,7 +88,7 @@ func runReleases(ctx *cli.Context) error {
return nil
}
// CmdReleaseCreate represents a sub command of Release to create release.
// CmdReleaseCreate represents a sub command of Release to create release
var CmdReleaseCreate = cli.Command{
Name: "create",
Usage: "Create a release",
@ -104,13 +128,13 @@ var CmdReleaseCreate = cli.Command{
Aliases: []string{"a"},
Usage: "List of files to attach",
},
}, LoginRepoFlags...),
}, AllDefaultFlags...),
}
func runReleaseCreate(ctx *cli.Context) error {
login, owner, repo := initCommand()
release, _, err := login.Client().CreateRelease(owner, repo, gitea.CreateReleaseOption{
release, resp, err := login.Client().CreateRelease(owner, repo, gitea.CreateReleaseOption{
TagName: ctx.String("tag"),
Target: ctx.String("target"),
Title: ctx.String("title"),
@ -120,10 +144,10 @@ func runReleaseCreate(ctx *cli.Context) error {
})
if err != nil {
if err.Error() == "409 Conflict" {
log.Fatal("error: There already is a release for this tag")
if resp != nil && resp.StatusCode == http.StatusConflict {
fmt.Println("error: There already is a release for this tag")
return nil
}
log.Fatal(err)
}
@ -146,3 +170,139 @@ func runReleaseCreate(ctx *cli.Context) error {
return nil
}
// CmdReleaseDelete represents a sub command of Release to delete a release
var CmdReleaseDelete = cli.Command{
Name: "delete",
Usage: "Delete a release",
Description: `Delete a release`,
Outdated
Review

[foo] indicates that foo is optional. release tag is not optional.

`[foo]` indicates that `foo` is optional. release tag is not optional.
ArgsUsage: "<release tag>",
Action: runReleaseDelete,
Flags: AllDefaultFlags,
}
func runReleaseDelete(ctx *cli.Context) error {
login, owner, repo := initCommand()
client := login.Client()
tag := ctx.Args().First()
if len(tag) == 0 {
fmt.Println("Release tag needed to delete")
return nil
}
release, err := getReleaseByTag(owner, repo, tag, client)
if err != nil {
return err
}
if release == nil {
return nil
}
_, err = client.DeleteRelease(owner, repo, release.ID)
return err
}
func getReleaseByTag(owner, repo, tag string, client *gitea.Client) (*gitea.Release, error) {
rl, _, err := client.ListReleases(owner, repo, gitea.ListReleasesOptions{})
if err != nil {
return nil, err
}
if len(rl) == 0 {
fmt.Println("Repo does not have any release")
return nil, nil
}
for _, r := range rl {
if r.TagName == tag {
return r, nil
}
}
fmt.Println("Release tag does not exist")
return nil, nil
}
// CmdReleaseEdit represents a sub command of Release to edit releases
6543 marked this conversation as resolved
Review

please add ArgsUsage: "<release tag>" to options

please add `ArgsUsage: "<release tag>"` to options
var CmdReleaseEdit = cli.Command{
Name: "edit",
Usage: "Edit a release",
Description: `Edit a release`,
ArgsUsage: "<release tag>",
Action: runReleaseEdit,
Flags: append([]cli.Flag{
&cli.StringFlag{
Name: "tag",
Usage: "Change Tag",
},
&cli.StringFlag{
Name: "target",
Usage: "Change Target",
},
&cli.StringFlag{
Name: "title",
Aliases: []string{"t"},
Usage: "Change Title",
},
&cli.StringFlag{
Name: "note",
Aliases: []string{"n"},
Usage: "Change Notes",
},
&cli.StringFlag{
Name: "draft",
Aliases: []string{"d"},
Usage: "Mark as Draft [True/false]",
DefaultText: "true",
},
&cli.StringFlag{
Name: "prerelease",
Aliases: []string{"p"},
Usage: "Mark as Pre-Release [True/false]",
DefaultText: "true",
6543 marked this conversation as resolved Outdated
Outdated
Review

what does this flag do? it's unclear to me, there already is a draft/prerelease flag.

what does this flag do? it's unclear to me, there already is a draft/prerelease flag.
Outdated
Review

releasea a "unreleased" release <- how should I describe it ?!?

releasea a "unreleased" release <- how should I describe it ?!?
Outdated
Review

Ah I get it now, after looking at the logic behind the flag.
I'd remove this flag, if you want to change the draft state, you can just use --draft=false flag.

Imo the use case does not exist where you intentionally set both --draft --prerelease on creation, and lateron want to remove both flags. (i.e. why initially set the prerelease flag then?)

Ah I get it now, after looking at the logic behind the flag. I'd remove this flag, if you want to change the draft state, you can just use `--draft=false` flag. Imo the use case does not exist where you intentionally set both `--draft --prerelease` on creation, and lateron want to remove both flags. (i.e. why initially set the prerelease flag then?)
},
}, AllDefaultFlags...),
}
func runReleaseEdit(ctx *cli.Context) error {
login, owner, repo := initCommand()
client := login.Client()
tag := ctx.Args().First()
if len(tag) == 0 {
fmt.Println("Release tag needed to edit")
6543 marked this conversation as resolved Outdated
Outdated
Review

should be ...to edit"

should be `...to edit"`
return nil
}
release, err := getReleaseByTag(owner, repo, tag, client)
if err != nil {
return err
}
if release == nil {
return nil
}
var isDraft, isPre *bool
bTrue := true
bFalse := false
if ctx.IsSet("draft") {
isDraft = &bFalse
if strings.ToLower(ctx.String("draft"))[:1] == "t" {
isDraft = &bTrue
}
}
if ctx.IsSet("prerelease") {
isPre = &bFalse
if strings.ToLower(ctx.String("prerelease"))[:1] == "t" {
isPre = &bTrue
}
}
_, _, err = client.EditRelease(owner, repo, release.ID, gitea.EditReleaseOption{
TagName: ctx.String("tag"),
Target: ctx.String("target"),
Title: ctx.String("title"),
Note: ctx.String("note"),
IsDraft: isDraft,
IsPrerelease: isPre,
})
return err
}