[Pull] Check Issue Subscription and display button based on that #445
Labels
No labels
⌚ Major-release
⌚ Minor-release
⚔️ Wontfix
⚙️ CI
⛏️ Breaking
✅ Fixed
✨ Duplicate
❌ Invalid
❓ Question
❤️ Support
➡️ Frontport
➡️ Needs-frontport
🔙 Backport
💭 Brainstorming
🐛 Bug
🔭 Cannot-reproduce
🧺 Cleanup
🧾 Confirmed
💬 Discussion
📄 Documentation
🎯 Enhancement
🩹 External-dependecy
📱 F-droid
🎉 Feature
👋 Good-first-issue
🤾 Google-play
🔙 Has-backport
🚀 Improvement
🚨 Investigate
🌠 Long-term
🔙 Needs-backport
🧺 Needs-cleanup
📡 Needs-feedback
📈 Performance
📌 Priority-critical
📌 Priority-high
📍 Priority-low
📍 Priority-medium
🥑 Ready
🪒 Refactor
🔙 Regression
📸 Release
🔒 Security
💡 Suggestion
🧪 Testing
🌐 Translation
💻 UI/UX
🪜 Upstream
🟦 Website
🙇♂️ Needs-help
🛰️ API-dependency
🛡️ Blocked
🏗️ Build
🗒️ Changelog
🗄️ Repository
🗓️ Summary
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: gitnex/GitNex#445
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
as described in #356
close #356
Original Pull att :https://gitea.com/gitnex/GitNex/pulls/445
Merged with:
e83b9eb736
PS: It als handle 200 responces from API - witch will be in >= 1.12
Comment from the issue, https://gitea.com/gitnex/GitNex/issues/356#issuecomment-112254
Tested and two things I noticed(one is just visual).
Swap the icons for subscribe/unsubscribe.
Even I am subscribed to an issue, it still shows subscribe. Upon tap to subscribe, it says issue subscribed which I was already subscribed to.
Can't attach as attachments are broken, but I guess you get the idea.
IssueDetailActivity.java has to set
issueSubscribed
, if you open the buttonsheet to fast it has not updated!!!you have to wait 1/2s to load the issue and then open the buttonsheet & your gitea version has to be 1.12 to test it
Maybe I was not clear, I just created new issue via web interface. Then I went to the same issue on the app and I see subscribe even I am subscribed to the issue. I haven't did anything on the app.
It should show subscribed.
where - we dont have a lable or some sort of indicatin to show the current subscribed state?
this is about the option to "de-subsubscribe" to an subscribed issue and visa versa
On a test server(local). I thought watchinfo will provide that label to know if user has subscribed to an issue or not.
I will have a deep look into it sometime tomorrow.
conflicts resolved :)
@mmarif ping :)
@6543 It works nicely on 1.12.
On 1.11.5 though I have noticed this. For all issues it shows Subscribe and when you subcribe, the bottomsheet is dimissed and when you trigger bottomsheet it shows unsubscribe. All good so far.
Now go back to the repository screen and come again to that same issue it shows subscribe again.
If it is not possible to properly to do it in 1.11.x, let's disable it for that version. As it gives wrong impression to users and they think why I need to subscribe again.
The icons also need to be flipped for subscribe and unsubscribe.
ToDo:
flip icons too<- they already do - @mmarif can you describe the issue more specific@mmarif ☝️
By flip I mean the filled icon should show when
Unsubscribe
is visible which means that you are already subscribed.Just swap line 87 and 99.
https://gitea.com/gitnex/GitNex/src/branch/master/app/src/main/res/layout/bottom_sheet_single_issue.xml
done