Check Issue Subscription and display button based on that #445

Tested and two things I noticed(one is just visual). Swap the icons for subscribe/unsubscribe. Even I am subscribed to an issue, it still shows subscribe. Upon tap to subscribe, it says issue subscribed which I was already subscribed to.

Screenshot_20200426_205448.png

40 KiB

Screenshot_20200426_205420.png

41 KiB

mmarif commented

2020-04-26 15:59:27 +00:00

Can't attach as attachments are broken, but I guess you get the idea.

6543 commented

2020-04-26 17:30:59 +00:00

IssueDetailActivity.java has to set issueSubscribed, if you open the buttonsheet to fast it has not updated!!!

you have to wait 1/2s to load the issue and then open the buttonsheet & your gitea version has to be 1.12 to test it

IssueDetailActivity.java has to set `issueSubscribed`, if you open the buttonsheet to fast it has not updated!!! you have to wait 1/2s to load the issue and then open the buttonsheet & your gitea version has to be 1.12 to test it

mmarif commented

2020-04-26 18:52:48 +00:00

Maybe I was not clear, I just created new issue via web interface. Then I went to the same issue on the app and I see subscribe even I am subscribed to the issue. I haven't did anything on the app.

It should show subscribed.

Maybe I was not clear, I just created new issue via web interface. Then I went to the same issue on the app and I see subscribe even I am subscribed to the issue. I haven't did anything on the app. It should show subscribed.

6543 commented

2020-04-26 21:07:03 +00:00

where - we dont have a lable or some sort of indicatin to show the current subscribed state?

this is about the option to "de-subsubscribe" to an subscribed issue and visa versa

where - we dont have a lable or some sort of indicatin to show the current subscribed state? this is about the option to "de-subsubscribe" to an subscribed issue and visa versa

mmarif commented

2020-04-26 23:07:41 +00:00

where

On a test server(local). I thought watchinfo will provide that label to know if user has subscribed to an issue or not.

I will have a deep look into it sometime tomorrow.

> where On a test server(local). I thought watchinfo will provide that label to know if user has subscribed to an issue or not. I will have a deep look into it sometime tomorrow.

6543 commented

2020-05-08 23:48:51 +00:00

conflicts resolved :)

6543 commented

2020-05-16 13:30:08 +00:00

@mmarif ping :)

mmarif commented

2020-05-17 18:07:44 +00:00

@6543 It works nicely on 1.12.

On 1.11.5 though I have noticed this. For all issues it shows Subscribe and when you subcribe, the bottomsheet is dimissed and when you trigger bottomsheet it shows unsubscribe. All good so far.
Now go back to the repository screen and come again to that same issue it shows subscribe again.

If it is not possible to properly to do it in 1.11.x, let's disable it for that version. As it gives wrong impression to users and they think why I need to subscribe again.

The icons also need to be flipped for subscribe and unsubscribe.

@6543 It works nicely on 1.12. On 1.11.5 though I have noticed this. For all issues it shows Subscribe and when you subcribe, the bottomsheet is dimissed and when you trigger bottomsheet it shows unsubscribe. All good so far. Now go back to the repository screen and come again to that same issue it shows subscribe again. If it is not possible to properly to do it in 1.11.x, let's disable it for that version. As it gives wrong impression to users and they think why I need to subscribe again. **The icons also need to be flipped for subscribe and unsubscribe.**

👍 1

6543 commented

2020-05-17 22:07:55 +00:00

ToDo:

Disable IssueSubscription for gitea <= 1.11
~~flip icons too~~ <- they already do - @mmarif can you describe the issue more specific

ToDo: * [x] Disable IssueSubscription for gitea <= 1.11 * [x] ~~flip icons too~~ <- they already do - @mmarif can you describe the issue more specific

6543 added the

WIP

label 2020-05-17 22:08:07 +00:00

6543 commented

2020-05-20 18:50:28 +00:00

@mmarif ☝️

6543 removed the

WIP

label 2020-05-20 18:50:42 +00:00

mmarif commented

2020-05-21 05:53:45 +00:00

By flip I mean the filled icon should show when Unsubscribe is visible which means that you are already subscribed.