gitnex/GitNex
gitnex/GitNex
Archived
14
57
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

Implement drafts, introduce Room persistence library for db #139

Open
mmarif wants to merge 25 commits from 15-comments-draft into master
pull from: 15-comments-draft
merge into: gitnex:master
Conversation 15 Commits 25 Files Changed 34 +2330 -347
mmarif commented 2019-10-12 18:18:49 +00:00
Owner
Copy Link

Will close #15 and #64.

To do:

  • Insert new user account to db or check for existing account
  • Get user account data
  • Insert repository data to db
  • Drafts list
  • Delete draft
  • Edit a draft via comment box
  • Draft information(belong to which repo and issue id)
  • Delete all drafts option - menu with bottom sheet
  • To recognize drafts per account for later use, save some info in user table on login
  • Save when user start typing in the comment box
  • Add type param to the table(comment, issue types etc) [for later use]
  • Check if draft exists, update only then
  • Force user logout
Will close #15 and #64. To do: - [x] Insert new user account to db or check for existing account - [x] Get user account data - [x] Insert repository data to db - [x] Drafts list - [x] Delete draft - [x] Edit a draft via comment box - [x] Draft information(belong to which repo and issue id) - [x] Delete all drafts option - menu with bottom sheet - [x] To recognize drafts per account for later use, save some info in user table on login - [x] Save when user start typing in the comment box - [x] Add type param to the table(comment, issue types etc) [for later use] - [x] Check if draft exists, update only then - [x] Force user logout
mmarif self-assigned this 2019-10-12 18:18:49 +00:00
mmarif added the
Feature
 label 2019-10-12 18:18:49 +00:00
mmarif added the
WIP
 label 2019-10-12 18:33:05 +00:00
6543 commented 2019-10-12 20:53:31 +00:00
Member
Copy Link

looking into ...

looking into ...
6543 commented 2019-10-13 01:25:17 +00:00
Member
Copy Link

We ned an indicator on the list wich shows where the draft come from ...
option to edit and send it or delete it

We ned an indicator on the list wich shows where the draft come from ... option to edit and send it or delete it
6543 commented 2019-10-13 01:27:02 +00:00
Member
Copy Link

I'm looking into the DB later on ...
-> #64 means we can solfe #28 in the future?

I'm looking into the DB later on ... -> https://gitea.com/gitnex/GitNex/issues/64 means we can solfe https://gitea.com/gitnex/GitNex/issues/28 in the future?
mmarif commented 2019-10-13 10:19:20 +00:00
Author
Owner
Copy Link

Yes, there are many things to do. I will update the 1st post with what need to be done.

I’m looking into the DB later on … -> #64 means we can solfe #28 in the future?

Yes

Yes, there are many things to do. I will update the 1st post with what need to be done. > I’m looking into the DB later on … -> #64 means we can solfe #28 in the future? Yes
👍 1
6543 added this to the 2.2.0 milestone 2019-10-14 08:38:29 +00:00
mmarif modified the milestone from 2.2.0 to 2.3.0 2019-10-14 15:02:31 +00:00
mmarif commented 2019-10-14 15:06:26 +00:00
Author
Owner
Copy Link

@6543 I have removed this from 2.2.0 release, as this is huge and a breaking change. Also it need more time.

I believe 2.3.0 is best for it as we can add more account and database related stuff into it to make it one change for all users.
The one thing which will be required is logout and login so the app can function properly.

@6543 I have removed this from 2.2.0 release, as this is huge and a breaking change. Also it need more time. I believe 2.3.0 is best for it as we can add more account and database related stuff into it to make it one change for all users. The one thing which will be required is logout and login so the app can function properly.
mmarif commented 2019-10-14 15:07:35 +00:00
Author
Owner
Copy Link

Also 2.2.0 is almost there to release. 👍

Also 2.2.0 is almost there to release. :+1:
6543 commented 2019-10-14 15:14:15 +00:00
Member
Copy Link

2.3.0 should then target gitea 1.10.0 because release is realy soon!

2.3.0 should then target gitea 1.10.0 because release is realy soon!
6543 commented 2019-10-14 15:15:21 +00:00
Member
Copy Link

-> so 2.2.0 is for 1.9.x & 1.8.x?

-> 2.3.0 is for 1.10.x and 1.9.x (no 100%) ... and dev 1.11.x ;)

@mmarif

-> so 2.2.0 is for 1.9.x & 1.8.x? -> 2.3.0 is for 1.10.x and 1.9.x (no 100%) ... and dev 1.11.x ;) @mmarif
mmarif commented 2019-10-14 15:24:55 +00:00
Author
Owner
Copy Link

I don't normally target any specific version of Gitea. Means, I don't delay GitNex release or wait for Gitea. I work with whatever is available. 😄

-> so 2.2.0 is for 1.9.x & 1.8.x?

Yes, including 1.10.0-dev.

-> 2.3.0 is for 1.10.x and 1.9.x (no 100%) … and dev 1.11.x ;)

If by that time Gitea 1.10 is out, then 1.9 and 1.10 for GitNex 2.3.0 release.

I don't normally target any specific version of Gitea. Means, I don't delay GitNex release or wait for Gitea. I work with whatever is available. :smile: > -> so 2.2.0 is for 1.9.x & 1.8.x? Yes, including 1.10.0-dev. > -> 2.3.0 is for 1.10.x and 1.9.x (no 100%) … and dev 1.11.x ;) If by that time Gitea 1.10 is out, then 1.9 and 1.10 for GitNex 2.3.0 release.
👍 1
mmarif commented 2019-10-14 15:29:28 +00:00
Author
Owner
Copy Link

But if by any chance, Gitea 1.10 is released before GitNex 2.2.0. Then we will support 1.8 too as the app is already supporting APIs on 1.8. 👍

But if by any chance, Gitea 1.10 is released before GitNex 2.2.0. Then we will support 1.8 too as the app is already supporting APIs on 1.8. :+1:
mmarif commented 2019-10-14 17:30:04 +00:00
Author
Owner
Copy Link

Seems around the corner. 👍

Seems around the corner. :+1:
mmarif added the
Breaking
 label 2019-10-16 15:53:46 +00:00
mmarif modified the milestone from 2.3.0 to 2.4.0 2019-10-30 14:50:46 +00:00
mmarif modified the milestone from 2.4.0 to 3.0.0 2019-12-03 12:28:14 +00:00
mmarif changed title from [WIP] Implementing drafts, introduced Room persistence library for db. to [WIP] Implement drafts, introduce Room persistence library for db 2020-04-13 08:07:29 +00:00
mmarif changed title from [WIP] Implement drafts, introduce Room persistence library for db to Implement drafts, introduce Room persistence library for db 2020-04-18 14:37:28 +00:00
mmarif added
LGTM-need
 and removed
WIP
 labels 2020-04-24 15:36:40 +00:00
mmarif commented 2020-04-24 15:37:24 +00:00
Author
Owner
Copy Link

It's ready. 🎉

@6543 @opyale

It's ready. :tada: @6543 @opyale
🎉 2
6543 commented 2020-04-24 15:41:43 +00:00
Member
Copy Link

pleace let me have a look at it - but this can take 1d ... today I have less time

pleace let me have a look at it - but this can take 1d ... today I have less time
mmarif commented 2020-04-24 15:53:09 +00:00
Author
Owner
Copy Link

pleace let me have a look at it - but this can take 1d ... today I have less time

Take your time. No rush.

> pleace let me have a look at it - but this can take 1d ... today I have less time Take your time. No rush.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
3.0.0
Assignees
Clear assignees
No Assignees
mmarif
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#139
No description provided.
Delete Branch "15-comments-draft"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?