#139 [WIP] Implementing drafts, introduced Room persistence library for db.

Open
mmarif wants to merge 5 commits from 15-comments-draft into master
mmarif commented 5 months ago

Will close #15 and #64.

To do:

  • Delete draft
  • Edit a draft
  • Draft information(belong to which repo and issue id)
  • Delete all drafts option
  • To recognize drafts per account for later use, save some info in user table on login
  • Draft button when commenting on issue
  • Delete draft when comment is posted

Note: by no means this PR or feature is completed. There is a lot of work to do. But the initial working draft is ready.

Will close #15 and #64. To do: - [ ] Delete draft - [ ] Edit a draft - [ ] Draft information(belong to which repo and issue id) - [ ] Delete all drafts option - [ ] To recognize drafts per account for later use, save some info in user table on login - [ ] Draft button when commenting on issue - [ ] Delete draft when comment is posted **Note**: by no means this PR or feature is completed. There is a lot of work to do. But the initial working draft is ready.
mmarif self-assigned this 5 months ago
mmarif added the
Feature
label 5 months ago
mmarif commented 5 months ago
Owner

screens

screens
mmarif added the
WIP
label 5 months ago
6543 commented 5 months ago
Collaborator

looking into ...

looking into ...
6543 commented 5 months ago
Collaborator

We ned an indicator on the list wich shows where the draft come from ... option to edit and send it or delete it

We ned an indicator on the list wich shows where the draft come from ... option to edit and send it or delete it
6543 commented 5 months ago
Collaborator

I’m looking into the DB later on ... -> #64 means we can solfe #28 in the future?

I'm looking into the DB later on ... -> https://gitea.com/gitnex/GitNex/issues/64 means we can solfe https://gitea.com/gitnex/GitNex/issues/28 in the future?
mmarif commented 5 months ago
Owner

Yes, there are many things to do. I will update the 1st post with what need to be done.

I’m looking into the DB later on … -> #64 means we can solfe #28 in the future?

Yes

Yes, there are many things to do. I will update the 1st post with what need to be done. > I’m looking into the DB later on … -> #64 means we can solfe #28 in the future? Yes
6543 added this to the 2.2.0 milestone 5 months ago
mmarif modified the milestone from 2.2.0 to 2.3.0 5 months ago
mmarif commented 5 months ago
Owner

@6543 I have removed this from 2.2.0 release, as this is huge and a breaking change. Also it need more time.

I believe 2.3.0 is best for it as we can add more account and database related stuff into it to make it one change for all users. The one thing which will be required is logout and login so the app can function properly.

@6543 I have removed this from 2.2.0 release, as this is huge and a breaking change. Also it need more time. I believe 2.3.0 is best for it as we can add more account and database related stuff into it to make it one change for all users. The one thing which will be required is logout and login so the app can function properly.
mmarif commented 5 months ago
Owner

Also 2.2.0 is almost there to release. :+1:

Also 2.2.0 is almost there to release. :+1:
6543 commented 5 months ago
Collaborator

2.3.0 should then target gitea 1.10.0 because release is realy soon!

2.3.0 should then target gitea 1.10.0 because release is realy soon!
6543 commented 5 months ago
Collaborator

-> so 2.2.0 is for 1.9.x & 1.8.x?

-> 2.3.0 is for 1.10.x and 1.9.x (no 100%) ... and dev 1.11.x ;)

@mmarif

-> so 2.2.0 is for 1.9.x & 1.8.x? -> 2.3.0 is for 1.10.x and 1.9.x (no 100%) ... and dev 1.11.x ;) @mmarif
mmarif commented 5 months ago
Owner

I don’t normally target any specific version of Gitea. Means, I don’t delay GitNex release or wait for Gitea. I work with whatever is available. :smile:

-> so 2.2.0 is for 1.9.x & 1.8.x?

Yes, including 1.10.0-dev.

-> 2.3.0 is for 1.10.x and 1.9.x (no 100%) … and dev 1.11.x ;)

If by that time Gitea 1.10 is out, then 1.9 and 1.10 for GitNex 2.3.0 release.

I don't normally target any specific version of Gitea. Means, I don't delay GitNex release or wait for Gitea. I work with whatever is available. :smile: > -> so 2.2.0 is for 1.9.x & 1.8.x? Yes, including 1.10.0-dev. > -> 2.3.0 is for 1.10.x and 1.9.x (no 100%) … and dev 1.11.x ;) If by that time Gitea 1.10 is out, then 1.9 and 1.10 for GitNex 2.3.0 release.
mmarif commented 5 months ago
Owner

But if by any chance, Gitea 1.10 is released before GitNex 2.2.0. Then we will support 1.8 too as the app is already supporting APIs on 1.8. :+1:

But if by any chance, Gitea 1.10 is released before GitNex 2.2.0. Then we will support 1.8 too as the app is already supporting APIs on 1.8. :+1:
mmarif commented 5 months ago
Owner

Seems around the corner. :+1:

Seems around the corner. :+1:
mmarif added the
Breaking
label 5 months ago
mmarif modified the milestone from 2.3.0 to 2.4.0 5 months ago
mmarif modified the milestone from 2.4.0 to 3.0.0 4 months ago
All checks were successful
continuous-integration/drone/pr Build is passing
This pull request has changes conflicting with the target branch.
app/build.gradle
app/src/main/AndroidManifest.xml
app/src/main/java/org/mian/gitnex/activities/MainActivity.java
app/src/main/res/values/strings.xml
Sign in to join this conversation.
Loading…
Cancel
Save
There is no content yet.