gitnex/GitNex
gitnex/GitNex
Archived
14
57
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

Repository PR List #198

Merged
mmarif merged 7 commits from 8-repo-pr-list into master 2019-11-24 12:43:01 +00:00
Conversation 10 Commits 7 Files Changed 39 +2345 -84
mmarif commented 2019-11-15 10:08:59 +00:00
Owner
Copy Link

Will close #8

  • PR list
  • Single pr view
  • DIff view
Will close #8 - [x] PR list - [x] Single pr view - [x] DIff view
mmarif added this to the 2.3.0 milestone 2019-11-15 10:08:59 +00:00
mmarif added the
Feature
 label 2019-11-15 10:08:59 +00:00
mmarif self-assigned this 2019-11-15 10:09:00 +00:00
6543 reviewed 2019-11-15 13:29:12 +00:00
Dismissed
6543 left a comment
Member

dont implement assignee anymore ...?

dont implement assignee anymore ...?
app/src/main/java/org/mian/gitnex/models/PullRequests.java
@ -0,0 +32,4 @@
private userObject user;
private List<labelsObject> labels;
private assigneeObject assignee;
6543 commented 2019-11-15 13:26:18 +00:00
Member

can drop L35 ?

can drop L35 ?
mmarif commented 2019-11-15 13:48:16 +00:00
Author
Owner

Yes, I will drop it.

Yes, I will drop it.
app/src/main/java/org/mian/gitnex/models/PullRequests.java
@ -0,0 +592,4 @@
}
}
public class assigneeObject {
6543 commented 2019-11-15 13:28:26 +00:00
Member

drop this class

drop this class
mmarif commented 2019-11-15 13:50:48 +00:00
Author
Owner

See my comment

See my comment
app/src/main/java/org/mian/gitnex/models/PullRequests.java
@ -0,0 +837,4 @@
return labels;
}
public assigneeObject getAssignee() {
6543 commented 2019-11-15 13:28:49 +00:00
Member

drop this func?

drop this func?
mmarif commented 2019-11-15 13:50:58 +00:00
Author
Owner

See my comment

See my comment
6543 commented 2019-11-15 13:30:51 +00:00
Member
Copy Link

If you dont have JSON Obj "assignee" gitea API ignore this ...
-> less redundancy ...
you get the same info + more from "assignees"

related to #196

If you dont have JSON Obj "assignee" gitea API ignore this ... -> less redundancy ... you get the same info + more from "assignees" related to https://gitea.com/gitnex/GitNex/issues/196
mmarif commented 2019-11-15 13:50:10 +00:00
Author
Owner
Copy Link

@6543 Sure, no problem. I will remove that part as it's not needed at this point.

Only thing I am worried is when creating new PR(future work) old versions of Gitea does not force assignee as mandatory. Then it will be a problem that time.

@6543 Sure, no problem. I will remove that part as it's not needed at this point. Only thing I am worried is when creating new PR(future work) old versions of Gitea does not force assignee as mandatory. Then it will be a problem that time.
6543 commented 2019-11-15 13:58:43 +00:00
Member
Copy Link

I think since 1.10.0 is out + 1.9.x support assignees and 1.8.x or below is riscy to use (securety ...) and the api stucture is not the same! (https://github.com/go-gitea/gitea/tree/release/v1.9/modules/structs) vs (https://github.com/go-gitea/gitea/tree/release/v1.8/modules/structs) we can drop this for next release I dont like to support 1.8.x and below! and 1.11.0 is on the way because a lot of refactoring has happend the next majior release is going out fast ...

I think since 1.10.0 is out + 1.9.x support assignee**s** and 1.8.x or below is riscy to use (securety ...) and the api stucture is not the same! (https://github.com/go-gitea/gitea/tree/release/v1.9/modules/structs) vs (https://github.com/go-gitea/gitea/tree/release/v1.8/modules/structs) we can drop this for next release I dont like to support 1.8.x and below! and 1.11.0 is on the way because a lot of refactoring has happend the next majior release is going out fast ...
mmarif commented 2019-11-15 16:56:19 +00:00
Author
Owner
Copy Link

@6543 I have removed assignee from model.

This PR is ready for testing.

Things to note:

  • Single PR comments view is not part of this PR. Only list of PRs.

Edit: There is not much difference of issue view and pr view, so will add single view for pr later in this PR.

@6543 I have removed assignee from model. This PR is ready for testing. Things to note: - Single PR comments view is not part of this PR. Only list of PRs. Edit: There is not much difference of issue view and pr view, so will add single view for pr later in this PR.
mmarif added the
LGTM-need
 label 2019-11-15 16:57:06 +00:00
6543 commented 2019-11-16 01:53:24 +00:00
Member
Copy Link

think two things have to implemented to be usefull again:

  • PR single view
  • PR count on the top of the tab (like at issues)

optional

  • unified way to display closed issues/PR
    • closed issues have it's own tab
    • closed PR are not visible anymore
think two things have to implemented to be usefull again: * [ ] PR single view * [ ] PR count on the top of the tab (like at issues) optional * [ ] unified way to display closed issues/PR - closed issues have it's own tab - closed PR are not visible anymore
mmarif commented 2019-11-16 04:50:59 +00:00
Author
Owner
Copy Link

Yes, I will add single view.

I forgot about the count, thanks for the reminder.

Closed pr, will add in another pr.

Yes, I will add single view. I forgot about the count, thanks for the reminder. Closed pr, will add in another pr.
mmarif changed title from Repository PR List to [WIP] Repository PR List 2019-11-16 08:27:49 +00:00
mmarif removed the
LGTM-need
 label 2019-11-16 08:27:58 +00:00
mmarif commented 2019-11-16 09:46:39 +00:00
Author
Owner
Copy Link

Adding counter is very tricky for PRs as the repo info does not provide the counter. And PR API return paged records.

Maybe adding it to the API /api/v1/repos/OWNER/REPO is best?

"open_pr_counter" : 2
Adding counter is very tricky for PRs as the repo info does not provide the counter. And PR API return paged records. Maybe adding it to the API `/api/v1/repos/OWNER/REPO` is best? ``` "open_pr_counter" : 2 ```
👍 1
6543 commented 2019-11-16 22:34:47 +00:00
Member
Copy Link

@mmarif I'll look into this (PR counter)

@mmarif I'll look into this (PR counter)
mmarif added the
LGTM-need
 label 2019-11-17 20:21:02 +00:00
mmarif commented 2019-11-17 20:21:23 +00:00
Author
Owner
Copy Link

This PR is ready for testing.

This PR is ready for testing.
👍 1
mmarif changed title from [WIP] Repository PR List to Repository PR List 2019-11-17 20:23:01 +00:00
6543 added
LGTM-done
 and removed
LGTM-need
 labels 2019-11-23 16:59:56 +00:00
6543 commented 2019-11-23 17:00:32 +00:00
Member
Copy Link

this need future features/improvement but I think it is ready for merge

this need future features/improvement but I think it is ready for merge
6543 approved these changes 2019-11-23 17:00:45 +00:00
Dismissed
mmarif referenced this issue from a commit 2019-11-24 12:43:00 +00:00
Repository PR List (#198)
mmarif closed this pull request 2019-11-24 12:43:00 +00:00
mmarif deleted branch 8-repo-pr-list 2019-11-24 12:43:28 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
2.3.0
Assignees
Clear assignees
No Assignees
mmarif
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#198
No description provided.
Delete Branch "8-repo-pr-list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?