#490 [WIP] Add Issue/Comment Reactions

Closed
opyale wants to merge 14 commits from <deleted>:layout-reactions into master
opyale commented 5 months ago

Closes #73

Closes #73
opyale added the
UI/UX
label 5 months ago
opyale added the
Improvement
label 5 months ago
opyale changed title from [WIP] Adding layout for reactions. to [WIP] Adding layouts for reactions. 5 months ago
6543 commented 5 months ago
ref: https://github.com/go-gitea/gitea/issues/11348 and https://github.com/go-gitea/gitea/issues/11330
mmarif commented 5 months ago

How this conversion API is going to work? trying to understand it. Will it be called for every emoji to convert to utf?

How this conversion API is going to work? trying to understand it. Will it be called for every emoji to convert to utf?
6543 commented 5 months ago

@mmarif it depends on how we define it :)

but if we use it to render a text with emoji alias to a text with utf8 we should have a look at
https://try.gitea.io/api/swagger#/miscellaneous/renderMarkdown and https://try.gitea.io/api/swagger#/miscellaneous/renderMarkdownRaw

@mmarif it depends on how we define it :) but if we use it to render a text with emoji alias to a text with utf8 we should have a look at https://try.gitea.io/api/swagger#/miscellaneous/renderMarkdown and https://try.gitea.io/api/swagger#/miscellaneous/renderMarkdownRaw
mmarif commented 5 months ago

So, if we need a rendered md data. We 1st need let's say a comment data and then send that to another API to return rendered data. Many comments, many double calls?

I feel if we use the current Android library md renderer is better as it is native and we don't need extra http calls.

Feel free to correct me here if I am getting this wrong. But at the end I would suggest we keep rendering of the md, emoji in the app itself.

So, if we need a rendered md data. We 1st need let's say a comment data and then send that to another API to return rendered data. Many comments, many double calls? I feel if we use the current Android library md renderer is better as it is native and we don't need extra http calls. Feel free to correct me here if I am getting this wrong. But at the end I would suggest we keep rendering of the md, emoji in the app itself.
6543 commented 5 months ago

@mmarif sure I also like to render it localy <- will have benefits at caching via roomDB later too, but reaction api at the moment only support alias like :tada: but not the utf8 equifaltent, so it only should create an api call if we have to resolve a new alias to utf8 to display it as reaction option. I also will have a look at preparing the reaction api to accept utf8

@mmarif sure I also like to render it localy <- will have benefits at caching via roomDB later too, but reaction api at the moment only support alias like `:tada:` but not the utf8 equifaltent, so it only should create an api call if we have to resolve a new alias to utf8 to display it as reaction option. I also will have a look at preparing the reaction api to accept utf8
opyale added 15 commits 5 months ago
ab8a5ed505 Clear cache, configure cache size (#482)
4e6057171b Adding deprecation dialog. (#492)
3de4dd9463 Refactor Version Checks (#472)
0f38d81cd0 Minor improvements concerning CI. (#498)
7bfdfa3223 Add/Remove new member to team (#483)
ad7c3696d5 [BugFix] Version Compare (#500)
opyale added the
LGTM-need
label 5 months ago
opyale changed title from [WIP] Adding layouts for reactions. to Adding layouts for reactions. 5 months ago
6543 added 1 commit 5 months ago
opyale added 2 commits 5 months ago
6543 added 1 commit 5 months ago
opyale self-assigned this 5 months ago
6543 changed title from Adding layouts for reactions. to Add Issue/Comment Reactions 5 months ago
6543 was assigned by opyale 5 months ago
6543 removed their assignment 5 months ago
6543 self-assigned this 5 months ago
opyale added 1 commit 5 months ago
opyale changed title from Add Issue/Comment Reactions to [WIP] Add Issue/Comment Reactions 5 months ago
opyale added 1 commit 5 months ago
opyale closed this pull request 4 months ago
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
3 Participants
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.