gitnex/GitNex
gitnex/GitNex
Archived
14
57
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

[WIP] Add Issue/Comment Reactions #490

Closed
opyale wants to merge 14 commits from (deleted):layout-reactions into master
pull from: (deleted):layout-reactions
merge into: gitnex:master
Conversation 5 Commits 14 Files Changed 11 +223 -34
opyale commented 2020-05-08 22:26:03 +00:00
Member
Copy Link

Closes #73

Closes #73
👍 2
opyale added the
UI/UX
Improvement
 labels 2020-05-08 22:26:42 +00:00
opyale changed title from [WIP] Adding layout for reactions. to [WIP] Adding layouts for reactions. 2020-05-08 22:28:33 +00:00
6543 commented 2020-05-09 00:12:00 +00:00
Member
Copy Link

ref: https://github.com/go-gitea/gitea/issues/11348
and https://github.com/go-gitea/gitea/issues/11330

ref: https://github.com/go-gitea/gitea/issues/11348 and https://github.com/go-gitea/gitea/issues/11330
mmarif commented 2020-05-09 05:05:50 +00:00
Owner
Copy Link

How this conversion API is going to work? trying to understand it. Will it be called for every emoji to convert to utf?

How this conversion API is going to work? trying to understand it. Will it be called for every emoji to convert to utf?
6543 commented 2020-05-09 06:35:51 +00:00
Member
Copy Link

@mmarif it depends on how we define it :)

but if we use it to render a text with emoji alias to a text with utf8 we should have a look at
https://try.gitea.io/api/swagger#/miscellaneous/renderMarkdown and https://try.gitea.io/api/swagger#/miscellaneous/renderMarkdownRaw

@mmarif it depends on how we define it :) but if we use it to render a text with emoji alias to a text with utf8 we should have a look at https://try.gitea.io/api/swagger#/miscellaneous/renderMarkdown and https://try.gitea.io/api/swagger#/miscellaneous/renderMarkdownRaw
mmarif commented 2020-05-09 07:01:32 +00:00
Owner
Copy Link

So, if we need a rendered md data. We 1st need let's say a comment data and then send that to another API to return rendered data. Many comments, many double calls?

I feel if we use the current Android library md renderer is better as it is native and we don't need extra http calls.

Feel free to correct me here if I am getting this wrong. But at the end I would suggest we keep rendering of the md, emoji in the app itself.

So, if we need a rendered md data. We 1st need let's say a comment data and then send that to another API to return rendered data. Many comments, many double calls? I feel if we use the current Android library md renderer is better as it is native and we don't need extra http calls. Feel free to correct me here if I am getting this wrong. But at the end I would suggest we keep rendering of the md, emoji in the app itself.
6543 commented 2020-05-09 08:08:16 +00:00
Member
Copy Link

@mmarif sure I also like to render it localy <- will have benefits at caching via roomDB later too, but reaction api at the moment only support alias like :tada: but not the utf8 equifaltent, so it only should create an api call if we have to resolve a new alias to utf8 to display it as reaction option. I also will have a look at preparing the reaction api to accept utf8

@mmarif sure I also like to render it localy <- will have benefits at caching via roomDB later too, but reaction api at the moment only support alias like `:tada:` but not the utf8 equifaltent, so it only should create an api call if we have to resolve a new alias to utf8 to display it as reaction option. I also will have a look at preparing the reaction api to accept utf8
opyale added 15 commits 2020-05-21 22:35:15 +00:00
Clear cache, configure cache size (#482) 
decrease the compression to have better results

Move cache size outside of maxsize method. fix progress bar alignment for files

Add cache size to picasso

Use getAbsolutePath

Merge branch 'app-cache' of gitea.com:gitnex/GitNex into app-cache

Few imprvoements

Merge branch 'master' into app-cache

small improvement

Implement configure cache size and clear it

Co-authored-by: 6543 <6543@noreply.gitea.io>
Reviewed-on: #482
Reviewed-by: opyale <opyale@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
ab8a5ed505
Adding deprecation dialog. (#492) 
Additional improvements.

Final improvements.

Adding deprecation dialog.

Reviewed-on: #492
Reviewed-by: M M Arif <mmarif@swatian.com>
Some checks failed
continuous-integration/drone/push Build is failing
Details
4e6057171b
Small layout adjustments and correcting typos.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
56d8cd0fac
Merge pull request 'Small layout adjustments and correcting typos.' (#493) from opyale/GitNex:settings-design-typo-adj into master 
Reviewed-on: #493
Reviewed-by: M M Arif <mmarif@swatian.com>
All checks were successful
continuous-integration/drone/push Build is passing
Details
29756511f3
Add corners to popup dialogs
All checks were successful
continuous-integration/drone/pr Build is passing
Details
a4afa5fbc2
Merge pull request 'Add corners to popup dialogs' (#495) from ui-enhancements into master 
Reviewed-on: #495
Reviewed-by: opyale <opyale@noreply.gitea.io>
All checks were successful
continuous-integration/drone/push Build is passing
Details
7f0689524f
Refactor Version Checks (#472) 
Merge branch 'master' into refactor-versionCheck

Merge branch 'master' into refactor-versionCheck

Revert "test CI"

This reverts commit b56eff0920.

test CI

Reformat LoginActivity.java

cleanup

migrate

Working + Tests

add first UnitTest

wip ...

enum2class

Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: #472
Reviewed-by: M M Arif <mmarif@swatian.com>
All checks were successful
continuous-integration/drone/push Build is passing
Details
3de4dd9463
Adding additional functionality.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
408fd9627b
Merge pull request 'Adding additional functionality to build upload.' (#497) from opyale/GitNex:ci-upload-reloaded into master 
Reviewed-on: #497
Reviewed-by: 6543 <6543@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
dd92ef9732
Minor improvements concerning CI. (#498) 
Minor improvements concerning CI

Reviewed-on: #498
Reviewed-by: 6543 <6543@noreply.gitea.io>
All checks were successful
continuous-integration/drone/push Build is passing
Details
0f38d81cd0
Add/Remove new member to team (#483) 
Search as user type, fix datalist.

Code Format

Fix users search theme

add and remove user from team

Add interface and user search and check for being team member or not

bottom sheet menu and few refactors

Co-authored-by: 6543 <6543@noreply.gitea.io>
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: #483
Reviewed-by: 6543 <6543@noreply.gitea.io>
Some checks failed
continuous-integration/drone/push Build is failing
Details
7bfdfa3223
[BugFix] Version Compare (#500) 
BugFix of Version

add new TestCase

Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: #500
Reviewed-by: M M Arif <mmarif@swatian.com>
Some checks failed
continuous-integration/drone/push Build is failing
Details
ad7c3696d5
Applying to pulls and issues.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e73b759222
opyale added the
LGTM-need
 label 2020-05-21 22:43:36 +00:00
opyale changed title from [WIP] Adding layouts for reactions. to Adding layouts for reactions. 2020-05-21 22:43:47 +00:00
6543 added 1 commit 2020-05-21 22:50:16 +00:00
Merge branch 'master' into layout-reactions
All checks were successful
continuous-integration/drone/pr Build is passing
Details
58cdf51260
opyale added 2 commits 2020-05-21 22:51:42 +00:00
Merge remote-tracking branch 'origin/layout-reactions' into layout-reactions
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ebc22b8977
6543 added 1 commit 2020-05-21 22:55:17 +00:00
Add IssueReactions
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ab21b2d524
opyale self-assigned this 2020-05-21 22:57:48 +00:00
6543 changed title from Adding layouts for reactions. to Add Issue/Comment Reactions 2020-05-21 22:58:43 +00:00
6543 was assigned by opyale 2020-05-21 22:59:26 +00:00
6543 removed their assignment 2020-05-21 23:00:30 +00:00
6543 self-assigned this 2020-05-21 23:00:44 +00:00
opyale added 1 commit 2020-05-21 23:45:19 +00:00
Merge branch 'master' into layout-reactions
All checks were successful
continuous-integration/drone/pr Build is passing
Details
634c810488
opyale changed title from Add Issue/Comment Reactions to [WIP] Add Issue/Comment Reactions 2020-05-21 23:45:36 +00:00
opyale added 1 commit 2020-05-22 09:56:58 +00:00
Moving reactions below time frame on comments.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
242d6af48b
opyale closed this pull request 2020-06-04 21:09:06 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Priority-high

   
Accepting-merge-requests

   
API

   
API-dependency

   
Backport

   
Blocked

   
Brainstorming

   
Breaking

Breaking change

  
Bug

   
Changelog

   
CI

   
Cleanup

   
Confirmed

   
Discussion

   
Documentation

   
Duplicate

   
Enhancement

   
External-dependecy

   
F-droid

   
Feature

   
Google-play

   
Improvement

   
Invalid

   
Investigate

   
LGTM-done

legitimation approved

  
LGTM-need

one approval required

  
Long-term

   
Major-release

   
Minor-release

   
Needs-cleanup

   
Needs-feedback

   
Needs-help

   
Priority-critical

   
Priority-low

   
Priority-medium

   
Question

   
Ready

Ready for testing

  
Refactor

   
Regression

   
Release

   
Repository

[Repository] Issues and PRs related to the app repo

  
Security

   
Suggestion

   
Support

   
Testing

   
Translation

   
UI/UX

   
Upstream

   
Website

[Website] Issues and PRs related to the app website

  
WIP
No Label
Priority-high
Accepting-merge-requests
API
API-dependency
Backport
Blocked
Brainstorming
Breaking
Bug
Changelog
CI
Cleanup
Confirmed
Discussion
Documentation
Duplicate
Enhancement
External-dependecy
F-droid
Feature
Google-play
Improvement
Invalid
Investigate
LGTM-done
LGTM-need
Long-term
Major-release
Minor-release
Needs-cleanup
Needs-feedback
Needs-help
Priority-critical
Priority-low
Priority-medium
Question
Ready
Refactor
Regression
Release
Repository
Security
Suggestion
Support
Testing
Translation
UI/UX
Upstream
Website
WIP
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
opyale
6543
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#490
No description provided.
Delete Branch "(deleted):layout-reactions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?