gitnex/GitNex
gitnex/GitNex
Archived
14
57
Fork 14
Code Issues Pull Requests 2 Releases 22 Wiki Activity

Fix infined load on Issues/Pulls if they dont exist #507

Merged
6543 merged 2 commits from fix-404-errors into master 2020-05-23 18:30:43 +00:00
Conversation 6 Commits 2 Files Changed 2 +26 -4
2 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/src/main/java/org/mian/gitnex/fragments/IssuesFragment.java
View File

@ -180,7 +180,7 @@ public class IssuesFragment extends Fragment {
@Override
public void onResponse(@NonNull Call<List<Issues>> call, @NonNull Response<List<Issues>> response) {
if(response.isSuccessful()) {
if(response.code() == 200) {
assert response.body() != null;
if(response.body().size() > 0) {
@ -192,11 +192,21 @@ public class IssuesFragment extends Fragment {
}
else {
issuesList.clear();
adapter.notifyDataChanged();
noDataIssues.setVisibility(View.VISIBLE);
}
mProgressBar.setVisibility(View.GONE);
}
else if(response.code() == 404) {
noDataIssues.setVisibility(View.VISIBLE);
mProgressBar.setVisibility(View.GONE);
}
else {
Log.e(TAG, String.valueOf(response.code()));
@ -227,7 +237,7 @@ public class IssuesFragment extends Fragment {
@Override
public void onResponse(@NonNull Call<List<Issues>> call, @NonNull Response<List<Issues>> response) {
if(response.isSuccessful()) {
if(response.code() == 200) {
//remove loading view
issuesList.remove(issuesList.size() - 1);

16
app/src/main/java/org/mian/gitnex/fragments/PullRequestsFragment.java
View File

@ -183,7 +183,7 @@ public class PullRequestsFragment extends Fragment {
@Override
public void onResponse(@NonNull Call<List<PullRequests>> call, @NonNull Response<List<PullRequests>> response) {
if(response.isSuccessful()) {
if(response.code() == 200) {
assert response.body() != null;
if(response.body().size() > 0) {
@ -195,14 +195,26 @@ public class PullRequestsFragment extends Fragment {
}
else {
prList.clear();
adapter.notifyDataChanged();
noData.setVisibility(View.VISIBLE);
}
mProgressBar.setVisibility(View.GONE);
}
else if(response.code() == 404) {
noData.setVisibility(View.VISIBLE);
mProgressBar.setVisibility(View.GONE);
}
else {
Log.i(TAG, String.valueOf(response.code()));
}
Log.i(TAG, String.valueOf(response.code()));
@ -232,7 +244,7 @@ public class PullRequestsFragment extends Fragment {
@Override
public void onResponse(@NonNull Call<List<PullRequests>> call, @NonNull Response<List<PullRequests>> response) {
if(response.isSuccessful()) {
if(response.code() == 200) {
//remove loading view
prList.remove(prList.size() - 1);