janse_zyd/xorm
1
0
Fork 0
forked from xorm/xorm
Code Issues Pull Requests Projects Releases Wiki Activity

master #1

Merged
janse_zyd merged 5 commits from xorm/xorm:master into master 2021-06-02 09:02:08 +00:00
Conversation 0 Commits 5 Files Changed 4 +134 -34
janse_zyd commented 2021-06-02 09:01:54 +00:00
Owner
Copy Link
No description provided.
janse_zyd added 5 commits 2021-06-02 09:01:54 +00:00
RFC: Use provided type to create the dstTable rather than inferring from the SQL types (#1872) 
When using dumptables to convert between dialects if a struct is provided we should use it to generate the SQL types rather than infer them by mapping from the sql types.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-on: xorm/xorm#1872
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-committed-by: Andrew Thornton <art27@cantab.net>
912c2524f8
Fix two issues with dumptables (#1903) 
There are two issues with #1872 which have become apparent
after testing on Gitea.

1. Ensure structs which are have before processors run correctly
2. Ensure structs extending other structs work
3. Ensure that numerical enums become numeric

Signed-off-by: Andrew Thornton <art27@cantab.net>

Reviewed-on: xorm/xorm#1903
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-committed-by: Andrew Thornton <art27@cantab.net>
210c30a7dd
Fix another bug with #1872 (#1905) 
Ensure that structs, arrays and slices are properly converted to strings.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Reviewed-on: xorm/xorm#1905
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-committed-by: Andrew Thornton <art27@cantab.net>
dab09c73ab
Byte strings in postgres aren't 0x... (#1906) 
Byte strings in postgres are actually E'\x...' not 0x...

This is part of the follow-up to #1872

Signed-off-by: Andrew Thornton <art27@cantab.net>

Reviewed-on: xorm/xorm#1906
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-committed-by: Andrew Thornton <art27@cantab.net>
d2f52eba64
janse_zyd merged commit 9d0d697b2a into master 2021-06-02 09:02:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: janse_zyd/xorm#1
No description provided.
Delete Branch "xorm/xorm:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?