Norwin noerw
2 Followers · 0 Following
Repositories
4
 Projects Public Activity Starred Repositories
4
noerw commented on pull request gitea/blog#241 2023-03-20 12:33:29 +00:00
Blog post for 1.19.0
noerw commented on pull request gitea/go-sdk#603 2023-02-16 17:16:47 +00:00
Add GetIssueTemplates()

@6543 merged current main.

could you add some tests?

currently don't have the time. also, from the PR head:

I didn't add tests because it would effectively just test gitea's API to…

noerw pushed to 547-issue-templates at noerw/go-sdk 2023-02-16 17:12:50 +00:00
f57a37fca7 Merge branch 'main' into 547-issue-templates
2d9ee57af1 update go.mod (#608)
1c9c71d84a Add ListPullRequestFiles (#607)
8f846bdb9b Update PullRequest struct (#606)
Compare 4 commits »
noerw deleted branch edit-issue from noerw/tea 2023-02-16 17:05:37 +00:00
noerw approved gitea/tea#514 2022-09-29 20:20:19 +00:00
Find DefaultPRHead based on branch and SHA
noerw suggested changes for gitea/tea#514 2022-09-29 20:17:10 +00:00
Find DefaultPRHead based on branch and SHA

never mind, this breaks the default values for me after futher testing:

noerw commented on pull request gitea/tea#514 2022-09-29 20:13:39 +00:00
Find DefaultPRHead based on branch and SHA

I still don't get the exact context where this helps, but it doesn't seem to break anything :)

noerw approved gitea/tea#514 2022-09-29 20:12:49 +00:00
Find DefaultPRHead based on branch and SHA
noerw pushed to edit-issue at noerw/tea 2022-09-29 11:18:39 +00:00
b235b1ba22 Merge branch 'main' into edit-issue
c1c7870ceb Handle Team Reviews (#515)
Compare 2 commits »
noerw commented on pull request gitea/tea#514 2022-09-29 11:16:33 +00:00
Find DefaultPRHead based on branch and SHA

I can't observe a difference in behaviour. Again, can you clarify what case is better handled with this?

noerw approved gitea/tea#517 2022-09-29 11:00:57 +00:00
Print pull dont crash if it has TeamReviewRequests
noerw commented on issue gitea/tea#516 2022-09-27 18:58:48 +00:00
Allow open pull request instead of issue when they are separated

Without fetching the issue by index and the repo settings, tea can't know what to do. We can of course add that, but it will make tea o <idx> non-instantaneous

noerw approved gitea/tea#515 2022-09-27 11:42:57 +00:00
Handle Team Reviews
noerw commented on pull request gitea/tea#515 2022-09-27 11:41:58 +00:00
Handle Team Reviews

:D I'd leave that out, @foo/bar clearly identifies this as a team already.

noerw approved gitea/tea#513 2022-09-27 11:37:18 +00:00
Add "json" as output type
noerw pushed to support_json_output at 6543/tea 2022-09-27 11:36:58 +00:00
b415ff13e2 add json to help of output flag
noerw commented on pull request gitea/tea#514 2022-09-27 11:32:41 +00:00
Find DefaultPRHead based on branch and SHA

Can you describe which case is enhanced with this?

This might give wrong / ambiguous results: Did you test what happens when you pass a sha to TeaFindBranchRemote() that is on multiple…

noerw commented on pull request gitea/tea#513 2022-09-27 11:24:53 +00:00
Add "json" as output type

I think the output flag needs to have json added as well

noerw approved gitea/tea#509 2022-09-27 11:20:28 +00:00
Add Allow Maintainer Edits

One nit, otherwise LGTM

noerw commented on pull request gitea/tea#509 2022-09-27 11:19:33 +00:00
Add Allow Maintainer Edits

isn't this missing a newline?